Re: [Libvirt-cim] [PATCH 2/3] RASD: Schema and Provider Support for Controller RASDs

On 03/13/2014 11:16 AM, Boris Fiuczynski wrote: > Just revisiting the mof again. > I am aware what KVM supports regarding controllers nut does LXC really > support controllers? Looking below at the mof... it apparently does! If > it does not than the class LXC_ControllerResourceAllocationSettingData > should be deleted! > Also I am not aware to what extend Xen supports controllers. Any ideas? > No idea about Xen, but in looking through the libvirt source code there is no reference to virDomainControllerDefPtr in any Xen driver, although are references to say virDomainDiskDefPtr, which is the libvirt corollary to disk definitions... And I believe you're right about LXC as well. It seems this change should be "constricted" to the KVM controller. I assume that would then also remove the Xen_* and LXC_* controller defs in the registration file too? Or we keep it there, but just empty? John

> On 03/03/2014 08:38 AM, Xu Wang wrote: >> Signed-off-by: Xu Wang <gesaint(a)linux.vnet.ibm.com&gt; >> --- >> schema/ResourceAllocationSettingData.mof | 27 +++++++++++++++++++++ >> schema/ResourceAllocationSettingData.registration | 3 ++ >> src/Virt_RASD.c | 24 ++++++++++++++++++ >> 3 files changed, 54 insertions(+), 0 deletions(-) >> >> diff --git a/schema/ResourceAllocationSettingData.mof b/schema/ResourceAllocationSettingData.mof >> index 6b649de..3512170 100644 >> --- a/schema/ResourceAllocationSettingData.mof >> +++ b/schema/ResourceAllocationSettingData.mof >> @@ -328,6 +328,33 @@ class LXC_InputResourceAllocationSettingData : LXC_ResourceAllocationSettingData >> string BusType; >> }; >> >> +[Description ("Xen virtual controller device"), >> + Provider("cmpi::Virt_RASD") >> +] >> +class Xen_ControllerResourceAllocationSettingData : Xen_ResourceAllocationSettingData >> +{ >> + string Type; >> + string Model; >> +}; >> + >> +[Description ("KVM virtual controller device"), >> + Provider("cmpi::Virt_RASD") >> +] >> +class KVM_ControllerResourceAllocationSettingData : KVM_ResourceAllocationSettingData >> +{ >> + string Type; >> + string Model; >> +}; >> + >> +[Description ("LXC virtual controller device"), >> + Provider("cmpi::Virt_RASD") >> +] >> +class LXC_ControllerResourceAllocationSettingData : LXC_ResourceAllocationSettingData >> +{ >> + string Type; >> + string Model; >> +}; >> + >> [Description ("Xen virtual network pool settings"), >> Provider("cmpi::Virt_RASD") >> ] > > > _______________________________________________ Libvirt-cim mailing list Libvirt-cim(a)redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim