Dan Smith wrote:
KR> I think this should be if (ret == -1) here.
Yep, thanks.
KR> No complaint, just a question - why is the count being hardcoded
KR> to 1 here?
Because I'm passing a single device instead of an array of devices.
The device_to_xml() function is used elsewhere to convert a single
device to xml, so this just acts as a type-detecting, list-faking,
wrapper to the concat_devxml() function. Since the concat_devxml()
function has a strange syntax and depends on internal-to-that-file
functions, it seems better to have an external interface that is a bit
more sane :)
Ah, yes. This makes more sense now. Thanks!
--
Kaitlin Rupert
IBM Linux Technology Center
karupert(a)us.ibm.com