Re: [Libvirt-cim] [PATCHv2 0/5] Initial Enablement of S390
On 08/29/2013 10:52 PM, John Ferlan wrote:
Things look good - cimtest and coverity tests both were happy.
Since I had already ACK'd patch 1 which is now patch 1 & 2, consider the
ACK still valid. Also the old patch 2 ACK is still valid even with the
self find of the missing qemu check.
I posted nits/questions separately about patches 4 & 5. Since I believe
you still need me to push, feel free to post either just a set of diffs
for me to squash into or a v3.
We will gladly accept your kind offer. Diffs are on
the way.
Is there a desire to get this into a RHEL release eventually or into the
"next" RHEL release? I'd rather let this "soak" a while and then
work
on getting a complete libvirt-cim into a future 6.n release over what I
have to do now which is patch 0.6.1 with 0.6.3 based patches...
No reason to hurry,
I'd also rather see this done well than quick.
And - not meant to scare you :) - we are not done yet.
There's a number of patches that we're still working on and will
send out for review soon. Not all are strictly s390 related, this first
series isn't either, but are needed to sensibly manage guests on
s390.
In case you (and others) are interested, the next patches will deal
with:
- full-functional consoles (mandatory for s390)
- device addresses
- per device boot order
- and some other minor libvirt feature exploitation support
Stay tuned...
--
Mit freundlichen Grüßen/Kind Regards
Viktor Mihajlovski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294