Re: [Libvirt-cim] [PATCH] [TEST] Add a 10 second delay at the beginning of the test to fix failure in running automatically

+1 for me. But, can we make inclusion of sleep() conditional depending on if virt != KVM or virt != LXC. Also, you can import the sleep as follows which looks much cleaner. *from time import sleep*

Thanks and Regards, Deepti. yunguol(a)cn.ibm.com wrote: > # HG changeset patch > # User Guolian Yun <yunguol(a)cn.ibm.com&gt; > # Date 1220596108 25200 > # Node ID bc36b82c6bd022d44824b3bf653fea1e915ba34d > # Parent d409f1d12edda62db577628693124c268a7d7da4 > [TEST] Add a 10 second delay at the beginning of the test to fix failure in running automatically > > Signed-off-by: Guolian Yun <yunguol(a)cn.ibm.com&gt; > > diff -r d409f1d12edd -r bc36b82c6bd0 suites/libvirt- cim/cimtest/LogicalDisk/02_nodevs.py > --- a/suites/libvirt-cim/cimtest/LogicalDisk/02_nodevs.py Wed Sep 03 22:54:35 2008 -0700 > +++ b/suites/libvirt-cim/cimtest/LogicalDisk/02_nodevs.py Thu Sep 04 23:28:28 2008 -0700 > @@ -25,6 +25,7 @@ > > import sys > import pywbem > +import time > from VirtLib import live > from XenKvmLib import devices > from CimTest.Globals import logger, CIM_ERROR_ENUMERATE > @@ -58,7 +59,7 @@ def main(): > "SystemCreationClassName"] > > cn = "LogicalDisk" > - > + time.sleep(10) > try: > devs = devices.enumerate(options.ip, cn, key_list,

> > diff -r d409f1d12edd -r bc36b82c6bd0 suites/libvirt- cim/cimtest/LogicalDisk/03_ld_gi_errs.py > --- a/suites/libvirt-cim/cimtest/LogicalDisk/03_ld_gi_errs.py Wed Sep 03 22:54:35 2008 -0700 > +++ b/suites/libvirt-cim/cimtest/LogicalDisk/03_ld_gi_errs.py Thu Sep 04 23:28:28 2008 -0700 > @@ -123,6 +123,7 @@ > > import sys > import pywbem > +import time > from VirtLib import utils > from XenKvmLib import assoc > from XenKvmLib import devices > @@ -172,7 +173,7 @@ def try_invalid_gi(i, field1, field2): > @do_main(sup_types) > def main(): > options = main.options > - > + time.sleep(10) > global classname > classname = get_typed_class(options.virt, 'LogicalDisk') > status = PASS > diff -r d409f1d12edd -r bc36b82c6bd0 suites/libvirt- cim/cimtest/Memory/01_memory.py > --- a/suites/libvirt-cim/cimtest/Memory/01_memory.py Wed Sep 03 22:54:35 2008 -0700 > +++ b/suites/libvirt-cim/cimtest/Memory/01_memory.py Thu Sep 04 23:28:28 2008 -0700 > @@ -24,6 +24,7 @@ > > import sys > import pywbem > +import time > from VirtLib import utils > from VirtLib import live > from XenKvmLib import devices > @@ -40,7 +41,7 @@ mem = 256 #MB > @do_main(sup_types) > def main(): > options = main.options > - > + time.sleep(10) > vsxml = get_class(options.virt)(test_dom, mem) > vsxml.define(options.ip) > alloc_mem = int(vsxml.xml_get_mem()) > diff -r d409f1d12edd -r bc36b82c6bd0 suites/libvirt- cim/cimtest/NetworkPort/01_netport.py > --- a/suites/libvirt-cim/cimtest/NetworkPort/01_netport.py Wed Sep 03 22:54:35 2008 -0700 > +++ b/suites/libvirt-cim/cimtest/NetworkPort/01_netport.py Thu Sep 04 23:28:28 2008 -0700 > @@ -31,6 +31,7 @@ > > import sys > import pywbem > +import time > from VirtLib import utils > from VirtLib import live > from XenKvmLib import devices > @@ -62,7 +63,7 @@ def get_linktech(ip, virt): > @do_main(sup_types) > def main(): > options = main.options > - > + time.sleep(10) > vsxml = get_class(options.virt)(test_dom, mac=test_mac) > vsxml.define(options.ip) > > diff -r d409f1d12edd -r bc36b82c6bd0 suites/libvirt- cim/cimtest/RASD/02_enum.py > --- a/suites/libvirt-cim/cimtest/RASD/02_enum.py Wed Sep 03 22: 54:35 2008 -0700 > +++ b/suites/libvirt-cim/cimtest/RASD/02_enum.py Thu Sep 04 23: 28:28 2008 -0700 > @@ -28,6 +28,7 @@ > > > import sys > +import time > from XenKvmLib import enumclass > from CimTest.Globals import logger, CIM_ERROR_ENUMERATE > from XenKvmLib.test_doms import destroy_and_undefine_all > @@ -115,6 +116,7 @@ def main(): > def main(): > virt = main.options.virt > server = main.options.ip > + time.sleep(10) > destroy_and_undefine_all(server) > global test_disk, vsxml > global procrasd, netrasd, diskrasd, memrasd > diff -r d409f1d12edd -r bc36b82c6bd0 suites/libvirt- cim/cimtest/ResourceAllocationFromPool/01_forward.py > --- a/suites/libvirt- cim/cimtest/ResourceAllocationFromPool/01_forward.py Wed Sep 03 22:54:35 2008 -0700 > +++ b/suites/libvirt- cim/cimtest/ResourceAllocationFromPool/01_forward.py Thu Sep 04 23:28:28 2008 -0700 > @@ -23,6 +23,7 @@ > # > > import sys > +import time > from VirtLib import utils > from XenKvmLib import assoc > from XenKvmLib import enumclass > @@ -114,7 +115,7 @@ def main(): > options = main.options > status = PASS > > - > + time.sleep(10) > status, vsxml, test_disk = setup_env(options.ip, options.virt) > if status != PASS: > vsxml.undefine(options.ip) > diff -r d409f1d12edd -r bc36b82c6bd0 suites/libvirt- cim/cimtest/ResourceAllocationFromPool/05_RAPF_err.py > --- a/suites/libvirt- cim/cimtest/ResourceAllocationFromPool/05_RAPF_err.py Wed Sep 03 22:54:35 2008 -0700 > +++ b/suites/libvirt- cim/cimtest/ResourceAllocationFromPool/05_RAPF_err.py Thu Sep 04 23:28:28 2008 -0700 > @@ -44,6 +44,7 @@ > # > import sys > import pywbem > +import time > import random > from VirtLib import live > from XenKvmLib import assoc, enumclass > @@ -203,7 +204,7 @@ def main(): > virt = options.virt > destroy_and_undefine_all(server) > in_list = [ 'bridge', 'network' ] > - > + time.sleep(10) > for interface in in_list: > # This is req bcs virsh does not support the defining a guest

> # when an invalid network poolname is passed. > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim > _______________________________________________ Libvirt-cim mailing list Libvirt-cim(a)redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim