Re: [Libvirt-cim] [PATCH] Fix externally-visible name of type_from_classname()

Friday, 2 November 2007


HE> What is your intention by breaking this one-liner into three lines ?

Because when I went to make this change:

@@ -467,7 +470,7 @@ static CMPIStatus get_device(const CMPIO
                                    conn,
                                    devid,
                                    NAMESPACE(reference),
-                                   type_from_classname(CLASSNAME(reference)));
+                                   device_type_from_classname(cn));

the line would wrap.  By consolidating all the CLASSNAME() calls into
a const char * (which is what I should have done in the first place) I
avoided wrapping that line :)

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms(a)us.ibm.com

    