Re: [Libvirt-cim] [PATCH] [TEST] Fix RAFP.02 failuer for KVM, using existing networkpool instead of creating a new one

yunguol(a)cn.ibm.com wrote: This fix works fine for this test case. The actual reason for this test case to fail is bcs of the difference in the networkpool used to define the guest and the pool used in the create_netpool_conf(). If we see the _set_vbridge() or set_vnetwork() of the vxml.py they make use of the networkpool/bridge information if they already exist or they create one, see below: def _set_vbridge(self, ip, virt_type): network_list = live.net_list(ip, virt=virt_type) if len(network_list) > 0: vbr = live.get_bridge_from_network_xml(network_list[0], ip, virt = virt_type) else: logger.info('No virutal network found') logger.info('Trying to create one ......') netxml = NetXML(ip, virt=virt_type) .................... AND def set_vnetwork(self, interface, virt_type): network_list = live.net_list(CIM_IP, virt_type) if len(network_list) > 0: nname = network_list[0] else: logger.info('No virutal network found') logger.info('Trying to create one ......') netxml = NetXML(CIM_IP, virt=virt_type) ret = netxml.create_vnet() 1) We might have to sync the function _set_vbridge() and set_vnetwork() to something similar to create_netpool_conf() funtion. OR And also, we do not need create_netpool_conf() in this test case as the call to vxml.define will internally call set_interface_details() and assign the network information accordingly. 2) Removing the create_netpool_conf() and either getting the bridge name using xml_get_net_bridge() or network name info by using xml_get_net_network() will also solve the failure seen in the test case. I think we should go with the approach 2 to solve the above test case problem, any thoughts ?? Thanks and Regards, Deepti.