Re: [Libvirt-cim] [PATCH 1 of 4] [TEST] Move cleanup_guest_netpool() to vsmigrations.py

>> + # completely successful VM might be created on the target >> machine + # and hence need to clean. >> + target_list = domain_list(t_sysname, virt) >> + if target_list != None and test_dom in target_list: >> + ret_value = cxml.destroy(t_sysname) >> > The ret_value from cxml.destroy is False and hence even though the VM > is getting destroyed we are getting the following false log: > Failed to destroy the migrated domain > 'VM_frm_elm3b217.beaverton.ibm.com' on 'localhost' > Thu, 28 May 2009 22:35:49:TEST LOG:INFO - Failed to destroy > the migrated domain 'VM_frm_elm3b217.beaverton.ibm.com' on 'localhost' > > use cxml.cim_destroy()instead. Good point - this should be cim_destroy(). > >> + if not ret_value: >> + logger.info("Failed to destroy the migrated domain '%s' >> on '%s'", >> + test_dom, t_sysname) >> + >> + ret_value = cxml.undefine(t_sysname) >> > Same here cxml.undefine() returns False and hence the following > statement gets printed. > Thu, 28 May 2009 22:52:39:TEST LOG:INFO - Failed to undefine > the migrated domain 'VM_frm_elm3b217.beaverton.ibm.com' on 'localhost' I'm not sure I understand.. if the guest fails to undefine, we should print an error. When you tested, did undefine() return false even when the guest was removed properly?

I was unable to reproduce this. >> + if not ret_value: >> + logger.info("Failed to undefine the migrated domain >> '%s' on '%s'", >> + test_dom, t_sysname) >> +