Re: [Libvirt-cim] [PATCH 00/10] cimtest: changes for controller and upstream support

On 04/21/2014 10:59 PM, Xu Wang wrote: > Dear John, > I just found an issue on RHEL-6.5. The reproduce steps, > 1. Install a pure RHEL-6.5 system and just use rhn updates from RedHat. > 2. Install and config libvirt-cim/cimtest just like before. > 3. Run cimtest, you will find lots of testcases failed like this, > InvodeMethod(DefineSystem): CIM_ERR_FAILED: Failed to define domain: > internal error Unknown controller type 'pci' with return code 1 > > The root cause of error is, default version of qemu-kvm from RHEL-6.5 is > 0.12.1.2-2, > too old for <controller type='pci' ...> (got that conclusion from link > http://libvirt.org > /formatdomain.html#elementsControllers). In my opinion, we should take > it into consideration, > or things like that will happen to the users who installed system like > that because not everyone > will update qemu to the newer version. My suggestion is, shall we adjust > cimtest a little? > Add a version checking into cimtest or just use another parameter > replace it (type='pci')? > > Thanks, > Xu Wang I'm assuming your step 2 is - you are attempting to compile and install the top of the libvirt-cim tree on your RHEL6.5 box - if not then you need to elaborate on what you mean by "just like before". Personally, this just says to me this code doesn't get back ported to RHEL6.5 - not that it would have been without a business justification anyway. I see this as a non issue as this is upstream only at this point. In general - if someone takes upstream code and tries to compile/run on downstream RHEL releases - they are on their own. It's cumbersome to keep track of what changes are applicable and when. If libvirt has have some sort of reliance on a specific qemu feature/release - it would use/check the capabilities of the qemu that exists on the machine and then provide the feature. I believe libvirt capability parsing was only recently added to the upstream libvirt-cim - see commit id '3e6f1489', which I'm fairly certain is not in the downstream code since I don't remember backporting it. John > 于 2014年04月22日 00:21, John Ferlan 写道: >> Do you feel outside of patch 1/10 that this series can be pushed once >> the controller series is pushed? With of course any "adjustments" to >> the numbers based on the libvirt-cim commit numbers. >> >> I can hold off on 1/10 and rework it later as there's just other things >> going on and I don't have the same issue since I don't use aliases on my >> localhost. >> >> Thanks, >> >> John >> _______________________________________________ Libvirt-cim mailing list Libvirt-cim(a)redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim