Re: [Libvirt-cim] [PATCH V3] Add dumpCore tag support to memory

On 08/19/2013 11:11 AM, Xu Wang wrote: > dumpCore tag in the <memory> is not supported by libvirt-cim and > it will be dropped during updating any element in the xml definition > of a domain. This patch keep the tag all the time. > > Signed-off-by: Xu Wang <gesaint(a)linux.vnet.ibm.com&gt; > --- > libxkutil/device_parsing.c | 28 +++++++++++++++++++++++++++- > libxkutil/device_parsing.h | 3 +++ > libxkutil/xmlgen.c | 9 +++++++++ > 3 files changed, 39 insertions(+), 1 deletions(-) > Hi, I am (again) writing to you only, as I am confused. With this patch you are obsoleting part of Thilo's patch to add support for the dumpCore tag. However, your version of the patch is not allowing to set the dumpCore, since it is lacking the RASD extension. How do you want to proceed, do you want us to rebase Thilo's patch on top of your version, once it gets accepted upstream? If so, that's fine with me and I would post a review comment on the libvirt-cim mailing list. If you plan to submit a patch for RASD support of dumpCore on your, please let me know, in which case we can spare us the effort of rebasing Thilo's patch.