Kaitlin Rupert wrote:
> + checklist = [[x.InstanceID, x.RegisteredOrganization,
> + x.RegisteredName, x.RegisteredVersion] for x in
> proflist]
> + for exp_prof in explist:
> + if exp_prof in checklist:
> + continue
> + else:
> + logger.error("Profile %s is not found" % exp_prof[0])
> + status = FAIL
You could reorganize this so that if the exp_prof isn't in the
checklist, you log an error and return a failure. Otherwise, you log
the info message and return.
Patch resent. Sorry for the delay.
> -
> -# The execution will reach here only if all the checks are
> successful - Globals.logger.log(int(Globals.logging.PRINT),
> "Verification of the properties \
> -for the class '%s' was successful", cn)
> + if status == PASS:
> + logger.info("Properties check for %s passed" % cn)
> return status
>
--
- Zhengang