[Libvirt-ci] Still Failing: libvirt/libvirt#1631 (master - 7e760f6)

Build Update for libvirt/libvirt ------------------------------------- Build: #1631 Status: Still Failing Duration: 21 mins and 34 secs Commit: 7e760f6 (master) Author: Marc Hartmayer Message: virDomainObjListAddLocked: fix double free If @vm has flagged as "to be removed" virDomainObjListFindByNameLocked returns NULL (although the definition actually exists). Therefore, the possibility exits that "virHashAddEntry" will raise the error "Duplicate key" => virDomainObjListAddObjLocked fails => virDomainObjEndAPI(&vm) is called and this leads to a freeing of @def since @def is already assigned to vm->def. But actually this leads to a double free since the common usage pattern is that the caller of virDomainObjListAdd(Locked) is responsible for freeing @def in case of an error. Let's fix this by setting vm->def to NULL in case of an error. Backtrace: ➤ bt #0 virFree (ptrptr=0x7575757575757575) #1 0x000003ffb5b25b3e in virDomainResourceDefFree #2 0x000003ffb5b37c34 in virDomainDefFree #3 0x000003ff9123f734 in qemuDomainDefineXMLFlags #4 0x000003ff9123f7f4 in qemuDomainDefineXML #5 0x000003ffb5cd2c84 in virDomainDefineXML #6 0x000000011745aa82 in remoteDispatchDomainDefineXML ... Reviewed-by: Bjoern Walk <bwalk(a)linux.ibm.com&gt; Signed-off-by: Marc Hartmayer <mhartmay(a)linux.ibm.com&gt; View the changeset: https://github.com/libvirt/libvirt/compare/6c5f6cdab95c...7e760f61577e View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/421949952?utm_source=email&a... -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications This email was sent to libvirt-ci(a)redhat.com (mailto:libvirt-ci@redhat.com) unsubscribe from this list (http://clicks.travis-ci.com/track/unsub.php?u=14313403&id=66d0e6c3ee7...)