New Defects reported by Coverity Scan for libvirt
by scan-admin＠coverity.com
Hi,
Please find the latest report on new defect(s) introduced to libvirt found with Coverity Scan.
2 new defect(s) introduced to libvirt found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 482738: Error handling issues (CHECKED_RETURN)
/src/hypervisor/domain_driver.c: 804 in virDomainDriverAutoShutdownDoSave()
_____________________________________________________________________________________________
*** CID 482738: Error handling issues (CHECKED_RETURN)
/src/hypervisor/domain_driver.c: 804 in virDomainDriverAutoShutdownDoSave()
798
799 if (virDomainManagedSave(domains[i], flags[i]) < 0) {
800 VIR_WARN("auto-shutdown: unable to perform managed save of '%s': %s",
801 domains[i]->name,
802 virGetLastErrorMessage());
803 if (flags[i] & VIR_DOMAIN_SAVE_RUNNING)
>>> CID 482738: Error handling issues (CHECKED_RETURN)
>>> Calling "virDomainResume" without checking return value (as is done elsewhere 4 out of 5 times).
804 virDomainResume(domains[i]);
805 continue;
806 }
807
808 modes[i] = 0;
809 }
** CID 482737: Error handling issues (CHECKED_RETURN)
/src/hypervisor/domain_driver.c: 785 in virDomainDriverAutoShutdownDoSave()
_____________________________________________________________________________________________
*** CID 482737: Error handling issues (CHECKED_RETURN)
/src/hypervisor/domain_driver.c: 785 in virDomainDriverAutoShutdownDoSave()
779 flags[i] = VIR_DOMAIN_SAVE_PAUSED;
780 }
781 if (cfg->saveBypassCache)
782 flags[i] |= VIR_DOMAIN_SAVE_BYPASS_CACHE;
783
784 if (flags[i] & VIR_DOMAIN_SAVE_RUNNING)
>>> CID 482737: Error handling issues (CHECKED_RETURN)
>>> Calling "virDomainSuspend" without checking return value (as is done elsewhere 5 out of 6 times).
785 virDomainSuspend(domains[i]);
786 }
787
788 if (!hasSave)
789 return;
790
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/libvirt?tab=overview
