August 2024 - CI - libvirt List Archives

New Defects reported by Coverity Scan for libvirt
by scan-admin＠coverity.com 10 Aug '24

10 Aug '24

Hi, Please find the latest report on new defect(s) introduced to libvirt found with Coverity Scan. 3 new defect(s) introduced to libvirt found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 467161: (CHECKED_RETURN) /src/ch/ch_monitor.c: 958 in virCHMonitorSaveVM() /src/ch/ch_monitor.c: 961 in virCHMonitorSaveVM() /src/ch/ch_monitor.c: 962 in virCHMonitorSaveVM() /src/ch/ch_monitor.c: 957 in virCHMonitorSaveVM() /src/ch/ch_monitor.c: 959 in virCHMonitorSaveVM() /src/ch/ch_monitor.c: 960 in virCHMonitorSaveVM() /src/ch/ch_monitor.c: 956 in virCHMonitorSaveVM() ________________________________________________________________________________________________________ *** CID 467161: (CHECKED_RETURN) /src/ch/ch_monitor.c: 958 in virCHMonitorSaveVM() 952 VIR_WITH_OBJECT_LOCK_GUARD(mon) { 953 /* reset all options of a libcurl session handle at first */ 954 curl_easy_reset(mon->handle); 955 956 curl_easy_setopt(mon->handle, CURLOPT_UNIX_SOCKET_PATH, mon->socketpath); 957 curl_easy_setopt(mon->handle, CURLOPT_URL, url); >>> CID 467161: (CHECKED_RETURN) >>> Calling "curl_easy_setopt(mon->handle, _curl_opt, "PUT")" without checking return value. This library function may fail and return an error code. 958 curl_easy_setopt(mon->handle, CURLOPT_CUSTOMREQUEST, "PUT"); 959 curl_easy_setopt(mon->handle, CURLOPT_HTTPHEADER, headers); 960 curl_easy_setopt(mon->handle, CURLOPT_POSTFIELDS, payload); 961 curl_easy_setopt(mon->handle, CURLOPT_WRITEFUNCTION, curl_callback); 962 curl_easy_setopt(mon->handle, CURLOPT_WRITEDATA, (void *)&data); 963 /src/ch/ch_monitor.c: 961 in virCHMonitorSaveVM() 955 956 curl_easy_setopt(mon->handle, CURLOPT_UNIX_SOCKET_PATH, mon->socketpath); 957 curl_easy_setopt(mon->handle, CURLOPT_URL, url); 958 curl_easy_setopt(mon->handle, CURLOPT_CUSTOMREQUEST, "PUT"); 959 curl_easy_setopt(mon->handle, CURLOPT_HTTPHEADER, headers); 960 curl_easy_setopt(mon->handle, CURLOPT_POSTFIELDS, payload); >>> CID 467161: (CHECKED_RETURN) >>> Calling "curl_easy_setopt(mon->handle, _curl_opt, curl_callback)" without checking return value. This library function may fail and return an error code. 961 curl_easy_setopt(mon->handle, CURLOPT_WRITEFUNCTION, curl_callback); 962 curl_easy_setopt(mon->handle, CURLOPT_WRITEDATA, (void *)&data); 963 964 responseCode = virCHMonitorCurlPerform(mon->handle); 965 } 966 /src/ch/ch_monitor.c: 962 in virCHMonitorSaveVM() 956 curl_easy_setopt(mon->handle, CURLOPT_UNIX_SOCKET_PATH, mon->socketpath); 957 curl_easy_setopt(mon->handle, CURLOPT_URL, url); 958 curl_easy_setopt(mon->handle, CURLOPT_CUSTOMREQUEST, "PUT"); 959 curl_easy_setopt(mon->handle, CURLOPT_HTTPHEADER, headers); 960 curl_easy_setopt(mon->handle, CURLOPT_POSTFIELDS, payload); 961 curl_easy_setopt(mon->handle, CURLOPT_WRITEFUNCTION, curl_callback); >>> CID 467161: (CHECKED_RETURN) >>> Calling "curl_easy_setopt(mon->handle, _curl_opt, (void *)&data)" without checking return value. This library function may fail and return an error code. 962 curl_easy_setopt(mon->handle, CURLOPT_WRITEDATA, (void *)&data); 963 964 responseCode = virCHMonitorCurlPerform(mon->handle); 965 } 966 967 if (responseCode == 200 || responseCode == 204) { /src/ch/ch_monitor.c: 957 in virCHMonitorSaveVM() 951 952 VIR_WITH_OBJECT_LOCK_GUARD(mon) { 953 /* reset all options of a libcurl session handle at first */ 954 curl_easy_reset(mon->handle); 955 956 curl_easy_setopt(mon->handle, CURLOPT_UNIX_SOCKET_PATH, mon->socketpath); >>> CID 467161: (CHECKED_RETURN) >>> Calling "curl_easy_setopt(mon->handle, _curl_opt, url)" without checking return value. This library function may fail and return an error code. 957 curl_easy_setopt(mon->handle, CURLOPT_URL, url); 958 curl_easy_setopt(mon->handle, CURLOPT_CUSTOMREQUEST, "PUT"); 959 curl_easy_setopt(mon->handle, CURLOPT_HTTPHEADER, headers); 960 curl_easy_setopt(mon->handle, CURLOPT_POSTFIELDS, payload); 961 curl_easy_setopt(mon->handle, CURLOPT_WRITEFUNCTION, curl_callback); 962 curl_easy_setopt(mon->handle, CURLOPT_WRITEDATA, (void *)&data); /src/ch/ch_monitor.c: 959 in virCHMonitorSaveVM() 953 /* reset all options of a libcurl session handle at first */ 954 curl_easy_reset(mon->handle); 955 956 curl_easy_setopt(mon->handle, CURLOPT_UNIX_SOCKET_PATH, mon->socketpath); 957 curl_easy_setopt(mon->handle, CURLOPT_URL, url); 958 curl_easy_setopt(mon->handle, CURLOPT_CUSTOMREQUEST, "PUT"); >>> CID 467161: (CHECKED_RETURN) >>> Calling "curl_easy_setopt(mon->handle, _curl_opt, headers)" without checking return value. This library function may fail and return an error code. 959 curl_easy_setopt(mon->handle, CURLOPT_HTTPHEADER, headers); 960 curl_easy_setopt(mon->handle, CURLOPT_POSTFIELDS, payload); 961 curl_easy_setopt(mon->handle, CURLOPT_WRITEFUNCTION, curl_callback); 962 curl_easy_setopt(mon->handle, CURLOPT_WRITEDATA, (void *)&data); 963 964 responseCode = virCHMonitorCurlPerform(mon->handle); /src/ch/ch_monitor.c: 960 in virCHMonitorSaveVM() 954 curl_easy_reset(mon->handle); 955 956 curl_easy_setopt(mon->handle, CURLOPT_UNIX_SOCKET_PATH, mon->socketpath); 957 curl_easy_setopt(mon->handle, CURLOPT_URL, url); 958 curl_easy_setopt(mon->handle, CURLOPT_CUSTOMREQUEST, "PUT"); 959 curl_easy_setopt(mon->handle, CURLOPT_HTTPHEADER, headers); >>> CID 467161: (CHECKED_RETURN) >>> Calling "curl_easy_setopt(mon->handle, _curl_opt, payload)" without checking return value. This library function may fail and return an error code. 960 curl_easy_setopt(mon->handle, CURLOPT_POSTFIELDS, payload); 961 curl_easy_setopt(mon->handle, CURLOPT_WRITEFUNCTION, curl_callback); 962 curl_easy_setopt(mon->handle, CURLOPT_WRITEDATA, (void *)&data); 963 964 responseCode = virCHMonitorCurlPerform(mon->handle); 965 } /src/ch/ch_monitor.c: 956 in virCHMonitorSaveVM() 950 951 952 VIR_WITH_OBJECT_LOCK_GUARD(mon) { 953 /* reset all options of a libcurl session handle at first */ 954 curl_easy_reset(mon->handle); 955 >>> CID 467161: (CHECKED_RETURN) >>> Calling "curl_easy_setopt(mon->handle, _curl_opt, mon->socketpath)" without checking return value. This library function may fail and return an error code. 956 curl_easy_setopt(mon->handle, CURLOPT_UNIX_SOCKET_PATH, mon->socketpath); 957 curl_easy_setopt(mon->handle, CURLOPT_URL, url); 958 curl_easy_setopt(mon->handle, CURLOPT_CUSTOMREQUEST, "PUT"); 959 curl_easy_setopt(mon->handle, CURLOPT_HTTPHEADER, headers); 960 curl_easy_setopt(mon->handle, CURLOPT_POSTFIELDS, payload); 961 curl_easy_setopt(mon->handle, CURLOPT_WRITEFUNCTION, curl_callback); ** CID 467160: Incorrect expression (BAD_SIZEOF) /src/ch/ch_monitor.c: 962 in virCHMonitorSaveVM() ________________________________________________________________________________________________________ *** CID 467160: Incorrect expression (BAD_SIZEOF) /src/ch/ch_monitor.c: 962 in virCHMonitorSaveVM() 956 curl_easy_setopt(mon->handle, CURLOPT_UNIX_SOCKET_PATH, mon->socketpath); 957 curl_easy_setopt(mon->handle, CURLOPT_URL, url); 958 curl_easy_setopt(mon->handle, CURLOPT_CUSTOMREQUEST, "PUT"); 959 curl_easy_setopt(mon->handle, CURLOPT_HTTPHEADER, headers); 960 curl_easy_setopt(mon->handle, CURLOPT_POSTFIELDS, payload); 961 curl_easy_setopt(mon->handle, CURLOPT_WRITEFUNCTION, curl_callback); >>> CID 467160: Incorrect expression (BAD_SIZEOF) >>> Taking the size of "&data", which is the address of an object, is suspicious. 962 curl_easy_setopt(mon->handle, CURLOPT_WRITEDATA, (void *)&data); 963 964 responseCode = virCHMonitorCurlPerform(mon->handle); 965 } 966 967 if (responseCode == 200 || responseCode == 204) { ** CID 467159: Error handling issues (CHECKED_RETURN) /src/ch/ch_monitor.c: 1005 in virCHMonitorBuildRestoreJson() ________________________________________________________________________________________________________ *** CID 467159: Error handling issues (CHECKED_RETURN) /src/ch/ch_monitor.c: 1005 in virCHMonitorBuildRestoreJson() 999 g_autoptr(virJSONValue) net_json = virJSONValueNewObject(); 1000 g_autofree char *id = g_strdup_printf("%s_%ld", CH_NET_ID_PREFIX, i); 1001 if (virJSONValueObjectAppendString(net_json, "id", id) < 0) 1002 return -1; 1003 if (virJSONValueObjectAppendNumberInt(net_json, "num_fds", vmdef->nets[i]->driver.virtio.queues)) 1004 return -1; >>> CID 467159: Error handling issues (CHECKED_RETURN) >>> Calling "virJSONValueArrayAppend" without checking return value (as is done elsewhere 34 out of 35 times). 1005 virJSONValueArrayAppend(nets, &net_json); 1006 } 1007 if (virJSONValueObjectAppend(restore_json, "net_fds", &nets)) 1008 return -1; 1009 } 1010 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

libvirt-rust | Failed pipeline for master | 771affba
by GitLab 10 Aug '24

10 Aug '24

Pipeline #1408044565 has failed! Project: libvirt-rust ( https://gitlab.com/libvirt/libvirt-rust ) Branch: master ( https://gitlab.com/libvirt/libvirt-rust/-/commits/master ) Commit: 771affba ( https://gitlab.com/libvirt/libvirt-rust/-/commit/771affba600b6853fe951b11eb… ) Commit Message: src: fix UAF of the stream pointer in drop meth... Commit Author: Ryosuke Yasuoka ( https://gitlab.com/ryasuoka ) Pipeline #1408044565 ( https://gitlab.com/libvirt/libvirt-rust/-/pipelines/1408044565 ) triggered by Daniel P_ Berrangé ( https://gitlab.com/berrange ) had 1 failed job. Job #7549898479 ( https://gitlab.com/libvirt/libvirt-rust/-/jobs/7549898479/raw ) Stage: builds Name: x86_64-fedora-40 -- You're receiving this email because of your account on gitlab.com.

1 0

libvirt-go-xml-module | Failed pipeline for master | a5be16b4
by GitLab 09 Aug '24

09 Aug '24

Pipeline #1407555022 has failed! Project: libvirt-go-xml-module ( https://gitlab.com/libvirt/libvirt-go-xml-module ) Branch: master ( https://gitlab.com/libvirt/libvirt-go-xml-module/-/commits/master ) Commit: a5be16b4 ( https://gitlab.com/libvirt/libvirt-go-xml-module/-/commit/a5be16b4b26ba559e… ) Commit Message: Add domain filesystem open files element Signe... Commit Author: Daniel P_ Berrangé ( https://gitlab.com/berrange ) Pipeline #1407555022 ( https://gitlab.com/libvirt/libvirt-go-xml-module/-/pipelines/1407555022 ) triggered by Daniel P_ Berrangé ( https://gitlab.com/berrange ) had 2 failed jobs. Job #7547225817 ( https://gitlab.com/libvirt/libvirt-go-xml-module/-/jobs/7547225817/raw ) Stage: build Name: go_1_11 Job #7547225828 ( https://gitlab.com/libvirt/libvirt-go-xml-module/-/jobs/7547225828/raw ) Stage: build Name: go_1_16 -- You're receiving this email because of your account on gitlab.com.

1 0

libvirt | Failed pipeline for master | 71f14351
by GitLab 09 Aug '24

09 Aug '24

Pipeline #1407468476 has failed! Project: libvirt ( https://gitlab.com/libvirt/libvirt ) Branch: master ( https://gitlab.com/libvirt/libvirt/-/commits/master ) Commit: 71f14351 ( https://gitlab.com/libvirt/libvirt/-/commit/71f14351f9b6ef3294c86df22751a7e… ) Commit Message: qemuxmlconftest: Add test cases for broken and ... Commit Author: Peter Krempa ( https://gitlab.com/pipo.sk ) Pipeline #1407468476 ( https://gitlab.com/libvirt/libvirt/-/pipelines/1407468476 ) triggered by Peter Krempa ( https://gitlab.com/pipo.sk ) had 2 failed jobs. Job #7546642602 ( https://gitlab.com/libvirt/libvirt/-/jobs/7546642602/raw ) Stage: builds Name: aarch64-macos-13 Job #7546642605 ( https://gitlab.com/libvirt/libvirt/-/jobs/7546642605/raw ) Stage: builds Name: aarch64-macos-14 -- You're receiving this email because of your account on gitlab.com.

1 0

libvirt | Successful pipeline for master | 66112fba
by GitLab 09 Aug '24

09 Aug '24

Pipeline #1407323582 has passed! Project: libvirt ( https://gitlab.com/libvirt/libvirt ) Branch: master ( https://gitlab.com/libvirt/libvirt/-/commits/master ) Commit: 66112fba ( https://gitlab.com/libvirt/libvirt/-/commit/66112fbabbba6cc5097f91acbe71d95… ) Commit Message: NEWS: Mention restore with n/w devices support ... Commit Author: Purna Pavan Chandra ( https://gitlab.com/pupacha ) Committed by: Michal Privoznik ( https://gitlab.com/mprivozn ) Pipeline #1407323582 ( https://gitlab.com/libvirt/libvirt/-/pipelines/1407323582 ) triggered by Michal Prívozník ( https://gitlab.com/MichalPrivoznik ) successfully completed 55 jobs in 4 stages. -- You're receiving this email because of your account on gitlab.com.

1 0

libvirt | Successful pipeline for master | 66112fba
by GitLab 09 Aug '24

09 Aug '24

Pipeline #1407323582 has passed! Project: libvirt ( https://gitlab.com/libvirt/libvirt ) Branch: master ( https://gitlab.com/libvirt/libvirt/-/commits/master ) Commit: 66112fba ( https://gitlab.com/libvirt/libvirt/-/commit/66112fbabbba6cc5097f91acbe71d95… ) Commit Message: NEWS: Mention restore with n/w devices support ... Commit Author: Purna Pavan Chandra ( https://gitlab.com/pupacha ) Committed by: Michal Privoznik ( https://gitlab.com/mprivozn ) Pipeline #1407323582 ( https://gitlab.com/libvirt/libvirt/-/pipelines/1407323582 ) triggered by Michal Prívozník ( https://gitlab.com/MichalPrivoznik ) successfully completed 55 jobs in 4 stages. -- You're receiving this email because of your account on gitlab.com.

1 0

libvirt | Successful pipeline for master | 14ca8ef2
by GitLab 09 Aug '24

09 Aug '24

Pipeline #1407298600 has passed! Project: libvirt ( https://gitlab.com/libvirt/libvirt ) Branch: master ( https://gitlab.com/libvirt/libvirt/-/commits/master ) Commit: 14ca8ef2 ( https://gitlab.com/libvirt/libvirt/-/commit/14ca8ef2560a5e36e1a7ac84a4de703… ) Commit Message: qemucapabilitiesdata: Update data for qemu-9.1 ... Commit Author: Peter Krempa ( https://gitlab.com/pipo.sk ) Pipeline #1407298600 ( https://gitlab.com/libvirt/libvirt/-/pipelines/1407298600 ) triggered by Peter Krempa ( https://gitlab.com/pipo.sk ) successfully completed 55 jobs in 4 stages. -- You're receiving this email because of your account on gitlab.com.

1 0

libvirt | Successful pipeline for master | 6d7dd09e
by GitLab 09 Aug '24

09 Aug '24

Pipeline #1406919396 has passed! Project: libvirt ( https://gitlab.com/libvirt/libvirt ) Branch: master ( https://gitlab.com/libvirt/libvirt/-/commits/master ) Commit: 6d7dd09e ( https://gitlab.com/libvirt/libvirt/-/commit/6d7dd09e8a3079409ceb7f08caa5318… ) Commit Message: qemu: format dma-translation on intel-iommu com... Commit Author: Sandesh Patel Committed by: Michal Privoznik ( https://gitlab.com/mprivozn ) Pipeline #1406919396 ( https://gitlab.com/libvirt/libvirt/-/pipelines/1406919396 ) triggered by Michal Prívozník ( https://gitlab.com/MichalPrivoznik ) successfully completed 55 jobs in 4 stages. -- You're receiving this email because of your account on gitlab.com.

1 0

libvirt | Successful pipeline for master | 11f6773f
by GitLab 09 Aug '24

09 Aug '24

Pipeline #1406731455 has passed! Project: libvirt ( https://gitlab.com/libvirt/libvirt ) Branch: master ( https://gitlab.com/libvirt/libvirt/-/commits/master ) Commit: 11f6773f ( https://gitlab.com/libvirt/libvirt/-/commit/11f6773f198636b80e73fb3f69adc83… ) Commit Message: qemu: Avoid false failure when resuming post-co... Commit Author: Jiri Denemark ( https://gitlab.com/jirkade ) Pipeline #1406731455 ( https://gitlab.com/libvirt/libvirt/-/pipelines/1406731455 ) triggered by Daniel P_ Berrangé ( https://gitlab.com/berrange ) successfully completed 55 jobs in 3 stages. -- You're receiving this email because of your account on gitlab.com.

1 0

libvirt-rust | Failed pipeline for master | 771affba
by GitLab 09 Aug '24

09 Aug '24

Pipeline #1406687638 has failed! Project: libvirt-rust ( https://gitlab.com/libvirt/libvirt-rust ) Branch: master ( https://gitlab.com/libvirt/libvirt-rust/-/commits/master ) Commit: 771affba ( https://gitlab.com/libvirt/libvirt-rust/-/commit/771affba600b6853fe951b11eb… ) Commit Message: src: fix UAF of the stream pointer in drop meth... Commit Author: Ryosuke Yasuoka ( https://gitlab.com/ryasuoka ) Pipeline #1406687638 ( https://gitlab.com/libvirt/libvirt-rust/-/pipelines/1406687638 ) triggered by Daniel P_ Berrangé ( https://gitlab.com/berrange ) had 1 failed job. Job #7541890777 ( https://gitlab.com/libvirt/libvirt-rust/-/jobs/7541890777/raw ) Stage: builds Name: x86_64-fedora-40 -- You're receiving this email because of your account on gitlab.com.

1 0