New Defects reported by Coverity Scan for libvirt
by scan-admin＠coverity.com
Hi,
Please find the latest report on new defect(s) introduced to libvirt found with Coverity Scan.
3 new defect(s) introduced to libvirt found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 461022: Concurrent data access violations (MISSING_LOCK)
/src/network/bridge_driver_linux.c: 345 in networkAddFirewallRules()
________________________________________________________________________________________________________
*** CID 461022: Concurrent data access violations (MISSING_LOCK)
/src/network/bridge_driver_linux.c: 345 in networkAddFirewallRules()
339 (virNetworkDefGetIPByIndex(def, AF_INET, 0) ||
340 virNetworkDefGetRouteByIndex(def, AF_INET, 0))) {
341 virSetError(errInitV4);
342 return -1;
343 }
344
>>> CID 461022: Concurrent data access violations (MISSING_LOCK)
>>> Accessing "errInitV6" without holding lock "virMutex.lock". Elsewhere, "errInitV6" is written to with "virMutex.lock" held 1 out of 1 times.
345 if (errInitV6 &&
346 (virNetworkDefGetIPByIndex(def, AF_INET6, 0) ||
347 virNetworkDefGetRouteByIndex(def, AF_INET6, 0) ||
348 def->ipv6nogw)) {
349 virSetError(errInitV6);
350 return -1;
** CID 461021: Concurrent data access violations (MISSING_LOCK)
/src/network/bridge_driver_linux.c: 338 in networkAddFirewallRules()
________________________________________________________________________________________________________
*** CID 461021: Concurrent data access violations (MISSING_LOCK)
/src/network/bridge_driver_linux.c: 338 in networkAddFirewallRules()
332 virFirewallBackend firewallBackend,
333 virFirewall **fwRemoval)
334 {
335
336 networkSetupPrivateChains(firewallBackend, false);
337
>>> CID 461021: Concurrent data access violations (MISSING_LOCK)
>>> Accessing "errInitV4" without holding lock "virMutex.lock". Elsewhere, "errInitV4" is written to with "virMutex.lock" held 1 out of 1 times.
338 if (errInitV4 &&
339 (virNetworkDefGetIPByIndex(def, AF_INET, 0) ||
340 virNetworkDefGetRouteByIndex(def, AF_INET, 0))) {
341 virSetError(errInitV4);
342 return -1;
343 }
** CID 461020: Concurrent data access violations (MISSING_LOCK)
/src/network/bridge_driver_linux.c: 183 in networkPreReloadFirewallRules()
________________________________________________________________________________________________________
*** CID 461020: Concurrent data access violations (MISSING_LOCK)
/src/network/bridge_driver_linux.c: 183 in networkPreReloadFirewallRules()
177 * rules if a network is later startup.
178 *
179 * Any errors here are saved to be reported at time
180 * of starting the network though as that makes them
181 * more likely to be seen by a human
182 */
>>> CID 461020: Concurrent data access violations (MISSING_LOCK)
>>> Accessing "chainInitDone" without holding lock "virMutex.lock". Elsewhere, "chainInitDone" is written to with "virMutex.lock" held 1 out of 1 times.
183 if (chainInitDone && force) {
184 /* The Private chains have already been initialized once
185 * during this run of libvirtd/virtnetworkd (known because
186 * chainInitDone == true) so we need to re-add the private
187 * chains even if there are currently no running networks,
188 * because the next time a network is started, libvirt will
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy...
