September 2017 - CI - libvirt List Archives

[Libvirt-ci] Fixed: libvirt/libvirt#553 (master - 89f0ea4)
by Travis CI 28 Sep '17

28 Sep '17

Build Update for libvirt/libvirt ------------------------------------- Build: #553 Status: Fixed Duration: 50 minutes and 42 seconds Commit: 89f0ea4 (master) Author: Daniel P. Berrange Message: Fix vxhs test to have stable certificate dir The test suite has hardcoded /etc/pki/qemu as the cert dir, but this only works if configure has --sysconfdir=/etc passed. We must set the vxhs cert dir to a stable path in the test suite. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> View the changeset: https://github.com/libvirt/libvirt/compare/6885b51e5f26...89f0ea419ddd View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/280976452?utm_source=email&utm… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

[Libvirt-ci] Broken: libvirt/libvirt#552 (master - 6885b51)
by Travis CI 28 Sep '17

28 Sep '17

Build Update for libvirt/libvirt ------------------------------------- Build: #552 Status: Broken Duration: 30 minutes and 7 seconds Commit: 6885b51 (master) Author: Ashish Mittal Message: qemu: Add TLS support for Veritas HyperScale (VxHS) Alter qemu command line generation in order to possibly add TLS for a suitably configured domain. Sample TLS args generated by libvirt - -object tls-creds-x509,id=objvirtio-disk0_tls0,dir=/etc/pki/qemu,\ endpoint=client,verify-peer=yes \ -drive file.driver=vxhs,file.tls-creds=objvirtio-disk0_tls0,\ file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc251,\ file.server.type=tcp,file.server.host=192.168.0.1,\ file.server.port=9999,format=raw,if=none,\ id=drive-virtio-disk0,cache=none \ -device virtio-blk-pci,bus=pci.0,addr=0x4,drive=drive-virtio-disk0,\ id=virtio-disk0 Update the qemuxml2argvtest with a couple of examples. One for a simple case and the other a bit more complex where multiple VxHS disks are added where at least one uses a VxHS that doesn't require TLS credentials and thus sets the domain disk source attribute "tls = 'no'". Update the hotplug to be able to handle processing the tlsAlias whether it's to add the TLS object when hotplugging a disk or to remove the TLS object when hot unplugging a disk. The hot plug/unplug code is largely generic, but the addition code does make the VXHS specific checks only because it needs to grab the correct config directory and generate the object as the command line would do. Signed-off-by: Ashish Mittal <Ashish.Mittal(a)veritas.com> Signed-off-by: John Ferlan <jferlan(a)redhat.com> View the changeset: https://github.com/libvirt/libvirt/compare/6209bb32e5b6...6885b51e5f26 View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/280887985?utm_source=email&utm… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

[Libvirt-ci] Build failed in Jenkins: virt-manager-master-check » libvirt-centos-7 #839
by ci＠centos.org 27 Sep '17

27 Sep '17

See <https://ci.centos.org/job/virt-manager-master-check/systems=libvirt-centos-…> ------------------------------------------ Started by upstream project "virt-manager-master-check" build number 839 originally caused by: Started by upstream project "virt-manager-master-build" build number 842 originally caused by: Started by upstream project "libvirt-python-master-build" build number 686 originally caused by: Started by upstream project "libvirt-master-build" build number 889 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on libvirt-centos-7 (libvirt) in workspace <https://ci.centos.org/job/virt-manager-master-check/systems=libvirt-centos-…> [virt-manager-master] $ /bin/sh -xe /tmp/jenkins2338811035137074889.sh + python setup.py test running test ..................................................................................................................................................................................................................................................................................................................................................................................................................................................... ---------------------------------------------------------------------- Ran 437 tests in 376.448s OK /tmp/jenkins2338811035137074889.sh: line 2: 7785 Segmentation fault (core dumped) python setup.py test Build step 'Execute shell' marked build as failure

1 1

[Libvirt-ci] Build failed in Jenkins: virt-manager-master-check » libvirt-centos-7 #837
by ci＠centos.org 26 Sep '17

26 Sep '17

See <https://ci.centos.org/job/virt-manager-master-check/systems=libvirt-centos-…> ------------------------------------------ Started by upstream project "virt-manager-master-check" build number 837 originally caused by: Started by upstream project "virt-manager-master-build" build number 840 originally caused by: Started by upstream project "libvirt-python-master-build" build number 684 originally caused by: Started by upstream project "libvirt-master-build" build number 887 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on libvirt-centos-7 (libvirt) in workspace <https://ci.centos.org/job/virt-manager-master-check/systems=libvirt-centos-…> [virt-manager-master] $ /bin/sh -xe /tmp/jenkins161251519698994060.sh + python setup.py test running test ..................................................................................................................................................................................................................................................................................................................................................................................................................................................... ---------------------------------------------------------------------- Ran 437 tests in 328.203s OK /tmp/jenkins161251519698994060.sh: line 2: 24725 Segmentation fault (core dumped) python setup.py test Build step 'Execute shell' marked build as failure

1 1

[Libvirt-ci] Build failed in Jenkins: virt-manager-master-check » libvirt-centos-7 #835
by ci＠centos.org 26 Sep '17

26 Sep '17

See <https://ci.centos.org/job/virt-manager-master-check/systems=libvirt-centos-…> ------------------------------------------ Started by upstream project "virt-manager-master-check" build number 835 originally caused by: Started by upstream project "virt-manager-master-build" build number 838 originally caused by: Started by upstream project "libvirt-python-master-build" build number 682 originally caused by: Started by upstream project "libvirt-master-build" build number 886 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on libvirt-centos-7 (libvirt) in workspace <https://ci.centos.org/job/virt-manager-master-check/systems=libvirt-centos-…> [virt-manager-master] $ /bin/sh -xe /tmp/jenkins955485278976948341.sh + python setup.py test running test ..................................................................................................................................................................................................................................................................................................................................................................................................................................................... ---------------------------------------------------------------------- Ran 437 tests in 383.743s OK /tmp/jenkins955485278976948341.sh: line 2: 4105 Segmentation fault (core dumped) python setup.py test Build step 'Execute shell' marked build as failure

1 1

[Libvirt-ci] Build failed in Jenkins: virt-manager-master-check » libvirt-centos-7 #830
by ci＠centos.org 22 Sep '17

22 Sep '17

See <https://ci.centos.org/job/virt-manager-master-check/systems=libvirt-centos-…> ------------------------------------------ Started by upstream project "virt-manager-master-check" build number 830 originally caused by: Started by upstream project "virt-manager-master-build" build number 833 originally caused by: Started by upstream project "libvirt-python-master-build" build number 677 originally caused by: Started by upstream project "libvirt-master-build" build number 879 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on libvirt-centos-7 (libvirt) in workspace <https://ci.centos.org/job/virt-manager-master-check/systems=libvirt-centos-…> [virt-manager-master] $ /bin/sh -xe /tmp/jenkins4360949693763344176.sh + python setup.py test running test ..................................................................................................................................................................................................................................................................................................................................................................................................................................................... ---------------------------------------------------------------------- Ran 437 tests in 367.186s OK /tmp/jenkins4360949693763344176.sh: line 2: 17915 Segmentation fault (core dumped) python setup.py test Build step 'Execute shell' marked build as failure

1 2

[Libvirt-ci] Build failed in Jenkins: libvirt-master-build » libvirt-freebsd #880
by ci＠centos.org 22 Sep '17

22 Sep '17

See <https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/880/…> Changes: [mprivozn] nss: Don't leak @ipAddr [jdenemar] util: Fix stack smashing in virNetDevGetFamilyId ------------------------------------------ [...truncated 146.22 KB...] CC qemu/libvirt_driver_qemu_impl_la-qemu_capabilities.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_command.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_parse_command.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_domain.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_domain_address.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_cgroup.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_hostdev.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_hotplug.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_process.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_migration.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_migration_cookie.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_monitor.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_monitor_text.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_monitor_json.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_driver.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_interface.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_security.lo CC bhyve/libvirt_driver_bhyve_impl_la-bhyve_capabilities.lo CC bhyve/libvirt_driver_bhyve_impl_la-bhyve_command.lo CC bhyve/libvirt_driver_bhyve_impl_la-bhyve_conf.lo CC bhyve/libvirt_driver_bhyve_impl_la-bhyve_parse_command.lo CC bhyve/libvirt_driver_bhyve_impl_la-bhyve_device.lo CC bhyve/libvirt_driver_bhyve_impl_la-bhyve_domain.lo CC bhyve/libvirt_driver_bhyve_impl_la-bhyve_driver.lo CC bhyve/libvirt_driver_bhyve_impl_la-bhyve_monitor.lo CC bhyve/libvirt_driver_bhyve_impl_la-bhyve_process.lo CC network/libvirt_driver_network_impl_la-bridge_driver.lo CC network/libvirt_driver_network_impl_la-bridge_driver_platform.lo CCLD libvirt_driver_secret.la CC storage/libvirt_driver_storage_impl_la-storage_driver.lo CC storage/libvirt_driver_storage_impl_la-storage_source.lo CC storage/libvirt_driver_storage_impl_la-storage_backend.lo CC storage/libvirt_driver_storage_impl_la-storage_util.lo CCLD libvirt-nss.la CCLD libvirt_storage_backend_fs.la CCLD libvirt_storage_backend_zfs.la GEN util/virkeycode-linux.7 GEN util/virkeycode-osx.7 GEN util/virkeycode-atset1.7 GEN util/virkeycode-atset2.7 GEN util/virkeycode-atset3.7 GEN util/virkeycode-xt.7 GEN util/virkeycode-xtkbd.7 GEN util/virkeycode-usb.7 GEN util/virkeycode-win32.7 GEN util/virkeycode-rfb.7 GEN util/virkeyname-linux.7 GEN util/virkeyname-osx.7 GEN util/virkeyname-win32.7 GEN virtlockd.8 GEN virtlogd.8 CCLD libvirt_util.la CCLD libvirt_conf.la CCLD libvirt_cpu.la CCLD libvirt_secret.la CCLD libvirt_vmx.la CCLD libvirt_driver.la CCLD libvirt_driver_test.la CCLD libvirt-net-rpc-client.la CCLD libvirt-net-rpc-server.la CCLD libvirt-net-rpc.la CCLD libvirt_driver_phyp.la CCLD libvirt_driver_vmware.la CCLD libvirt_driver_esx.la CCLD libvirt_security_manager.la CCLD libvirt_driver_access.la CCLD lockd.la CCLD libvirt_driver_vbox_impl.la CCLD libvirt_driver_qemu_impl.la CCLD libvirt_driver_bhyve_impl.la CCLD libvirt_driver_network_impl.la CCLD libvirt_driver_storage_impl.la CCLD libvirt_iohelper CCLD libvirt_leaseshelper CCLD virtlockd CCLD virtlogd CCLD libvirt_driver_remote.la CCLD libvirt_driver_vbox.la CCLD libvirt_driver_qemu.la CCLD libvirt_driver_network.la CCLD libvirt_driver_bhyve.la CCLD libvirt_driver_storage.la CCLD libvirt.la CCLD libvirt-qemu.la CCLD libvirt-lxc.la CCLD libvirt-admin.la rm util/virkeycode-xtkbd.pod util/virkeycode-atset3.pod util/virkeycode-usb.pod util/virkeycode-xt.pod util/virkeycode-win32.pod util/virkeyname-linux.pod util/virkeycode-osx.pod util/virkeycode-linux.pod util/virkeyname-osx.pod util/virkeycode-atset1.pod util/virkeycode-rfb.pod util/virkeyname-win32.pod util/virkeycode-atset2.pod gmake[3]: Leaving directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> gmake[2]: Leaving directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> Making all in daemon gmake[2]: Entering directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> GEN libvirtd.policy GEN libvirtd.qemu.logrotate GEN libvirtd.lxc.logrotate GEN libvirtd.libxl.logrotate GEN libvirtd.uml.logrotate GEN libvirtd.logrotate gmake all-am gmake[3]: Entering directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> CC libvirtd_conf_la-libvirtd-config.lo GEN remote_dispatch.h GEN lxc_dispatch.h GEN qemu_dispatch.h GEN admin_dispatch.h CC libvirtd_admin_la-admin_server.lo CC libvirtd-libvirtd.o CC libvirtd-remote.o CC libvirtd-stream.o GEN libvirtd.8.in GEN test_libvirtd.aug CCLD libvirtd_conf.la CC libvirtd_admin_la-admin.lo GEN libvirtd.8 CCLD libvirtd_admin.la CCLD libvirtd gmake[3]: Leaving directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> gmake[2]: Leaving directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> Making all in tools gmake[2]: Entering directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> GEN libvirt-guests.sh gmake all-am gmake[3]: Entering directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> CC libvirt_shell_la-vsh.lo CC virsh-virsh.o CC virsh-virsh-console.o CC virsh-virsh-domain.o CC virsh-virsh-domain-monitor.o CC virsh-virsh-host.o CC virsh-virsh-interface.o CC virsh-virsh-network.o CC virsh-virsh-nodedev.o CC virsh-virsh-nwfilter.o CC virsh-virsh-pool.o CC virsh-virsh-secret.o CC virsh-virsh-snapshot.o CC virsh-virsh-util.o CC virsh-virsh-volume.o CC virt_admin-virt-admin.o CC virt_host_validate-virt-host-validate.o CC virt_host_validate-virt-host-validate-common.o CC virt_host_validate-virt-host-validate-qemu.o CC virt_host_validate-virt-host-validate-bhyve.o GEN virt-xml-validate GEN virt-pki-validate GEN virt-pki-validate.1.in GEN virt-xml-validate.1.in GEN virt-admin.1.in GEN virsh.1.in GEN virt-host-validate.1.in CC nss/nss_libnss_libvirt_impl_la-libvirt_nss.lo CC nss/nss_libnss_libvirt_guest_impl_la-libvirt_nss.lo ../../tools/nss/libvirt_nss.c:646:22: error: use of undeclared identifier 'ipAaddr'; did you mean 'ipAddr'? VIR_FREE(ipAaddr); ^~~~~~~ ipAddr ../../src/util/viralloc.h:554:47: note: expanded from macro 'VIR_FREE' # define VIR_FREE(ptr) virFree(1 ? (void *) &(ptr) : (ptr)) ^ ../../tools/nss/libvirt_nss.c:629:15: note: 'ipAddr' declared here char *ipAddr = NULL; ^ ../../tools/nss/libvirt_nss.c:646:22: error: use of undeclared identifier 'ipAaddr'; did you mean 'ipAddr'? VIR_FREE(ipAaddr); ^~~~~~~ ipAddr ../../src/util/viralloc.h:554:55: note: expanded from macro 'VIR_FREE' # define VIR_FREE(ptr) virFree(1 ? (void *) &(ptr) : (ptr)) ^ ../../tools/nss/libvirt_nss.c:629:15: note: 'ipAddr' declared here char *ipAddr = NULL; ^ ../../tools/nss/libvirt_nss.c:658:18: error: use of undeclared identifier 'ipAaddr'; did you mean 'ipAddr'? VIR_FREE(ipAaddr); ^~~~~~~ ipAddr ../../src/util/viralloc.h:554:47: note: expanded from macro 'VIR_FREE' # define VIR_FREE(ptr) virFree(1 ? (void *) &(ptr) : (ptr)) ^ ../../tools/nss/libvirt_nss.c:629:15: note: 'ipAddr' declared here char *ipAddr = NULL; ^ ../../tools/nss/libvirt_nss.c:658:18: error: use of undeclared identifier 'ipAaddr'; did you mean 'ipAddr'? VIR_FREE(ipAaddr); ^~~~~~~ ipAddr ../../src/util/viralloc.h:554:55: note: expanded from macro 'VIR_FREE' # define VIR_FREE(ptr) virFree(1 ? (void *) &(ptr) : (ptr)) ^ ../../tools/nss/libvirt_nss.c:629:15: note: 'ipAddr' declared here char *ipAddr = NULL; ^ 4 errors generated. ../../tools/nss/libvirt_nss.c:646Makefile:2808: recipe for target 'nss/nss_libnss_libvirt_impl_la-libvirt_nss.lo' failed gmake[3]: *** [nss/nss_libnss_libvirt_impl_la-libvirt_nss.lo] Error 1 gmake[3]: *** Waiting for unfinished jobs.... :22: error: use of undeclared identifier 'ipAaddr'; did you mean 'ipAddr'? VIR_FREE(ipAaddr); ^~~~~~~ ipAddr ../../src/util/viralloc.h:554:47: note: expanded from macro 'VIR_FREE' # define VIR_FREE(ptr) virFree(1 ? (void *) &(ptr) : (ptr)) ^ ../../tools/nss/libvirt_nss.c:629:15: note: 'ipAddr' declared here char *ipAddr = NULL; ^ ../../tools/nss/libvirt_nss.c:646:22: error: use of undeclared identifier 'ipAaddr'; did you mean 'ipAddr'? VIR_FREE(ipAaddr); ^~~~~~~ ipAddr ../../src/util/viralloc.h:554:55: note: expanded from macro 'VIR_FREE' # define VIR_FREE(ptr) virFree(1 ? (void *) &(ptr) : (ptr)) ^ ../../tools/nss/libvirt_nss.c:629:15: note: 'ipAddr' declared here char *ipAddr = NULL; ^ ../../tools/nss/libvirt_nss.c:658:18: error: use of undeclared identifier 'ipAaddr'; did you mean 'ipAddr'? VIR_FREE(ipAaddr); ^~~~~~~ ipAddr ../../src/util/viralloc.h:554:47: note: expanded from macro 'VIR_FREE' # define VIR_FREE(ptr) virFree(1 ? (void *) &(ptr) : (ptr)) ^ ../../tools/nss/libvirt_nss.c:629:15: note: 'ipAddr' declared here char *ipAddr = NULL; ^ ../../tools/nss/libvirt_nss.c:658:18: error: use of undeclared identifier 'ipAaddr'; did you mean 'ipAddr'? VIR_FREE(ipAaddr); ^~~~~~~ ipAddr ../../src/util/viralloc.h:554:55: note: expanded from macro 'VIR_FREE' # define VIR_FREE(ptr) virFree(1 ? (void *) &(ptr) : (ptr)) ^ ../../tools/nss/libvirt_nss.c:629:15: note: 'ipAddr' declared here char *ipAddr = NULL; ^ 4 errors generated. Makefile:2801: recipe for target 'nss/nss_libnss_libvirt_guest_impl_la-libvirt_nss.lo' failed gmake[3]: *** [nss/nss_libnss_libvirt_guest_impl_la-libvirt_nss.lo] Error 1 gmake[3]: Leaving directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> Makefile:2407: recipe for target 'all' failed gmake[2]: *** [all] Error 2 gmake[2]: Leaving directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> Makefile:2114: recipe for target 'all-recursive' failed gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory '/usr<https://ci.centos.org/job/libvirt-master-build/systems=libvirt-freebsd/ws/b…'> Makefile:2007: recipe for target 'all' failed gmake: *** [all] Error 2 Build step 'Execute shell' marked build as failure

1 2

[Libvirt-ci] Passed: libvirt/libvirt#533 (master - 8a573f7)
by Travis CI 22 Sep '17

22 Sep '17

Build Update for libvirt/libvirt ------------------------------------- Build: #533 Status: Passed Duration: 6 minutes and 11 seconds Commit: 8a573f7 (master) Author: Michal Privoznik Message: libvirt_nss.c: Fix typo in aiforaf() In my previous commit of b1d87f9ad96f I've made a typo breaking the FreeBSD build. s/ipAaddr/ipAddr/ Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> View the changeset: https://github.com/libvirt/libvirt/compare/eba2225bc526...8a573f7c0c34 View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/278579202?utm_source=email&utm… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

[Libvirt-ci] Failed: libvirt/libvirt#533 (master - 8a573f7)
by Travis CI 22 Sep '17

22 Sep '17

Build Update for libvirt/libvirt ------------------------------------- Build: #533 Status: Failed Duration: 34 minutes and 40 seconds Commit: 8a573f7 (master) Author: Michal Privoznik Message: libvirt_nss.c: Fix typo in aiforaf() In my previous commit of b1d87f9ad96f I've made a typo breaking the FreeBSD build. s/ipAaddr/ipAddr/ Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> View the changeset: https://github.com/libvirt/libvirt/compare/eba2225bc526...8a573f7c0c34 View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/278579202?utm_source=email&utm… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0

[Libvirt-ci] Passed: libvirt/libvirt#532 (master - eba2225)
by Travis CI 22 Sep '17

22 Sep '17

Build Update for libvirt/libvirt ------------------------------------- Build: #532 Status: Passed Duration: 31 minutes and 44 seconds Commit: eba2225 (master) Author: Guido Günther Message: apparmor: delete profile on VM shutdown instead of only unloading it. This makes sure old profiles don't pile up in /etc/apparmor.d/libvirt and we get updates to modified templates on VM restart. Reviewed-by: Jim Fehlig <jfehlig(a)suse.com> View the changeset: https://github.com/libvirt/libvirt/compare/17825e8ae783...eba2225bc526 View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/278569829?utm_source=email&utm… -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

1 0