See
<
https://ci.centos.org/job/libvirt-build/systems=libvirt-fedora-28/427/dis...
Changes:
[jdenemar] news: Document parallel migration
[eblake] snapshot: Drop pointless function virDomainMomentIsCurrentName
[eblake] snapshot: Allow NULL to virDomainSnapshotObjGetDef
[eblake] snapshot: Refactor qemu to utilize virDomainMoment more
------------------------------------------
[...truncated 147.77 KB...]
CC util/libvirt_util_la-virnetlink.lo
CC util/libvirt_util_la-virnodesuspend.lo
CC util/libvirt_util_la-virkmod.lo
CC util/libvirt_util_la-virnuma.lo
CC util/libvirt_util_la-virobject.lo
CC util/libvirt_util_la-virpci.lo
CC util/libvirt_util_la-virpidfile.lo
CC util/libvirt_util_la-virpolkit.lo
CC util/libvirt_util_la-virportallocator.lo
CC util/libvirt_util_la-virprocess.lo
CC util/libvirt_util_la-virqemu.lo
CC util/libvirt_util_la-virrandom.lo
CC util/libvirt_util_la-virresctrl.lo
CC util/libvirt_util_la-virrotatingfile.lo
CC util/libvirt_util_la-virscsi.lo
CC util/libvirt_util_la-virscsihost.lo
CC util/libvirt_util_la-virscsivhost.lo
CC util/libvirt_util_la-virseclabel.lo
CC util/libvirt_util_la-virsecret.lo
CC util/libvirt_util_la-virsexpr.lo
CC util/libvirt_util_la-virsocketaddr.lo
CC util/libvirt_util_la-virstorageencryption.lo
CC util/libvirt_util_la-virstoragefile.lo
CC util/libvirt_util_la-virstoragefilebackend.lo
CC util/libvirt_util_la-virstring.lo
CC util/libvirt_util_la-virsysinfo.lo
CC util/libvirt_util_la-virsystemd.lo
CC util/libvirt_util_la-virthread.lo
CC util/libvirt_util_la-virthreadjob.lo
CC util/libvirt_util_la-virthreadpool.lo
CC util/libvirt_util_la-virtime.lo
CC util/libvirt_util_la-virtpm.lo
CC util/libvirt_util_la-virtypedparam.lo
CC util/libvirt_util_la-virusb.lo
CC util/libvirt_util_la-viruri.lo
CC util/libvirt_util_la-virutil.lo
CC util/libvirt_util_la-viruuid.lo
CC util/libvirt_util_la-virvhba.lo
CC util/libvirt_util_la-virvsock.lo
CC util/libvirt_util_la-virxml.lo
CC util/libvirt_util_la-virmdev.lo
CC util/libvirt_util_la-virfilecache.lo
CC conf/libvirt_conf_la-netdev_bandwidth_conf.lo
CC conf/libvirt_conf_la-netdev_vport_profile_conf.lo
CC conf/libvirt_conf_la-netdev_vlan_conf.lo
CC conf/libvirt_conf_la-capabilities.lo
CC conf/libvirt_conf_la-domain_addr.lo
CC conf/libvirt_conf_la-domain_capabilities.lo
CC conf/libvirt_conf_la-domain_conf.lo
CC conf/libvirt_conf_la-domain_audit.lo
CC conf/libvirt_conf_la-domain_nwfilter.lo
CC conf/libvirt_conf_la-virsavecookie.lo
CC conf/libvirt_conf_la-moment_conf.lo
CC conf/libvirt_conf_la-snapshot_conf.lo
CC conf/libvirt_conf_la-numa_conf.lo
CC conf/libvirt_conf_la-virdomainobjlist.lo
CC conf/libvirt_conf_la-virdomainmomentobjlist.lo
CC conf/libvirt_conf_la-virdomainsnapshotobjlist.lo
CC conf/libvirt_conf_la-object_event.lo
CC conf/libvirt_conf_la-domain_event.lo
CC conf/libvirt_conf_la-network_event.lo
CC conf/libvirt_conf_la-storage_event.lo
CC conf/libvirt_conf_la-node_device_event.lo
CC conf/libvirt_conf_la-secret_event.lo
CC conf/libvirt_conf_la-network_conf.lo
CC conf/libvirt_conf_la-virnetworkobj.lo
CC conf/libvirt_conf_la-networkcommon_conf.lo
CC conf/libvirt_conf_la-nwfilter_params.lo
CC conf/libvirt_conf_la-nwfilter_ipaddrmap.lo
CC conf/libvirt_conf_la-nwfilter_conf.lo
CC conf/libvirt_conf_la-virnwfilterobj.lo
CC conf/libvirt_conf_la-virnwfilterbindingdef.lo
CC conf/libvirt_conf_la-virnwfilterbindingobj.lo
CC conf/libvirt_conf_la-virnwfilterbindingobjlist.lo
CC conf/libvirt_conf_la-node_device_conf.lo
CC conf/libvirt_conf_la-node_device_util.lo
CC conf/libvirt_conf_la-virnodedeviceobj.lo
CC conf/libvirt_conf_la-storage_adapter_conf.lo
CC conf/libvirt_conf_la-storage_capabilities.lo
CC conf/libvirt_conf_la-storage_conf.lo
CC conf/libvirt_conf_la-virstorageobj.lo
CC conf/libvirt_conf_la-interface_conf.lo
CC conf/libvirt_conf_la-virinterfaceobj.lo
CC conf/libvirt_conf_la-secret_conf.lo
CC conf/libvirt_conf_la-virsecretobj.lo
CC conf/libvirt_conf_la-cpu_conf.lo
CC conf/libvirt_conf_la-virchrdev.lo
CC conf/libvirt_conf_la-device_conf.lo
CC cpu/libvirt_cpu_la-cpu.lo
CC cpu/libvirt_cpu_la-cpu_x86.lo
CC cpu/libvirt_cpu_la-cpu_s390.lo
CC cpu/libvirt_cpu_la-cpu_arm.lo
CC cpu/libvirt_cpu_la-cpu_ppc64.lo
CC cpu/libvirt_cpu_la-cpu_map.lo
CC security/libvirt_security_manager_la-security_driver.lo
CC security/libvirt_security_manager_la-security_nop.lo
CC security/libvirt_security_manager_la-security_stack.lo
CC security/libvirt_security_manager_la-security_dac.lo
CC security/libvirt_security_manager_la-security_manager.lo
CC security/libvirt_security_manager_la-security_util.lo
CC security/libvirt_security_manager_la-security_selinux.lo
CC access/libvirt_driver_access_la-viraccessperm.lo
CC access/libvirt_driver_access_la-viraccessmanager.lo
CC access/libvirt_driver_access_la-viraccessdrivernop.lo
CC access/libvirt_driver_access_la-viraccessdriverstack.lo
CC access/libvirt_driver_access_la-viraccessapicheck.lo
CC access/libvirt_driver_access_la-viraccessapicheckqemu.lo
CC access/libvirt_driver_access_la-viraccessapichecklxc.lo
CC access/libvirt_driver_access_la-viraccessdriverpolkit.lo
CC rpc/libvirt_net_rpc_la-virnetmessage.lo
CC rpc/libvirt_net_rpc_la-virnettlscontext.lo
CC rpc/libvirt_net_rpc_la-virnetsocket.lo
CC rpc/libvirt_net_rpc_la-virkeepalive.lo
CC rpc/libvirt_net_rpc_la-virnetprotocol.lo
CC rpc/libvirt_net_rpc_la-virkeepaliveprotocol.lo
CC rpc/libvirt_net_rpc_la-virnetsshsession.lo
CC rpc/libvirt_net_rpc_la-virnetsaslcontext.lo
CC rpc/libvirt_net_rpc_la-virnetlibsshsession.lo
CC rpc/libvirt_net_rpc_server_la-virnetserverprogram.lo
CC rpc/libvirt_net_rpc_server_la-virnetserverservice.lo
CC rpc/libvirt_net_rpc_server_la-virnetserverclient.lo
CC rpc/libvirt_net_rpc_server_la-virnetservermdns.lo
CC rpc/libvirt_net_rpc_server_la-virnetdaemon.lo
CC rpc/libvirt_net_rpc_server_la-virnetserver.lo
CC rpc/libvirt_net_rpc_client_la-virnetclientprogram.lo
CC rpc/libvirt_net_rpc_client_la-virnetclientstream.lo
CC rpc/libvirt_net_rpc_client_la-virnetclient.lo
CC phyp/libvirt_driver_phyp_la-phyp_driver.lo
CC test/libvirt_driver_test_la-test_driver.lo
CC esx/libvirt_driver_esx_la-esx_driver.lo
CC esx/libvirt_driver_esx_la-esx_interface_driver.lo
CC esx/libvirt_driver_esx_la-esx_network_driver.lo
CC esx/libvirt_driver_esx_la-esx_storage_driver.lo
CC esx/libvirt_driver_esx_la-esx_storage_backend_vmfs.lo
CC esx/libvirt_driver_esx_la-esx_storage_backend_iscsi.lo
CC esx/libvirt_driver_esx_la-esx_stream.lo
CC esx/libvirt_driver_esx_la-esx_util.lo
CC esx/libvirt_driver_esx_la-esx_vi.lo
CC esx/libvirt_driver_esx_la-esx_vi_methods.lo
CC esx/libvirt_driver_esx_la-esx_vi_types.lo
CC hyperv/libvirt_driver_hyperv_la-hyperv_driver.lo
CC hyperv/libvirt_driver_hyperv_la-hyperv_util.lo
CC hyperv/libvirt_driver_hyperv_la-hyperv_wmi.lo
CC hyperv/libvirt_driver_hyperv_la-hyperv_wmi_classes.lo
CC vmx/libvirt_vmx_la-vmx.lo
CC vmware/libvirt_driver_vmware_la-vmware_driver.lo
CC vmware/libvirt_driver_vmware_la-vmware_conf.lo
CC openvz/libvirt_driver_openvz_la-openvz_conf.lo
CC openvz/libvirt_driver_openvz_la-openvz_driver.lo
CC openvz/libvirt_driver_openvz_la-openvz_util.lo
CC xenconfig/libvirt_xenconfig_la-xen_common.lo
CC xenconfig/libvirt_xenconfig_la-xen_sxpr.lo
CC xenconfig/libvirt_xenconfig_la-xen_xm.lo
CC secret/libvirt_secret_la-secret_util.lo
CC remote/libvirt_driver_remote_la-remote_driver.lo
CC remote/libvirt_driver_remote_la-remote_protocol.lo
CC remote/libvirt_driver_remote_la-lxc_protocol.lo
CC remote/libvirt_driver_remote_la-qemu_protocol.lo
CC logging/libvirt_driver_la-log_protocol.lo
CC logging/libvirt_driver_la-log_manager.lo
CC locking/libvirt_driver_la-lock_manager.lo
CC locking/libvirt_driver_la-lock_driver_nop.lo
CC locking/libvirt_driver_la-domain_lock.lo
GEN libvirt_probes.lo
CC admin/libvirt_admin_la-admin_protocol.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_glue.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_driver.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_snapshot_conf.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_0.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_1.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_2.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_2_20.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_3.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_3_4.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_V5_0.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_V5_1.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_V5_2.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_common.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_network.lo
CC vbox/libvirt_driver_vbox_impl_la-vbox_storage.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_agent.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_alias.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_block.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_blockjob.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_capabilities.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_command.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_parse_command.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_domain.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_domain_address.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_cgroup.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_extdevice.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_firmware.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_hostdev.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_hotplug.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_process.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_migration.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_migration_cookie.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_migration_params.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_monitor.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_monitor_text.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_monitor_json.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_driver.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_interface.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_security.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_qapi.lo
CC qemu/libvirt_driver_qemu_impl_la-qemu_tpm.lo
GEN libvirt_qemu_probes.lo
CC libxl/libvirt_driver_libxl_impl_la-libxl_conf.lo
CC libxl/libvirt_driver_libxl_impl_la-libxl_capabilities.lo
CC libxl/libvirt_driver_libxl_impl_la-libxl_domain.lo
CC libxl/libvirt_driver_libxl_impl_la-libxl_driver.lo
CC libxl/libvirt_driver_libxl_impl_la-libxl_logger.lo
CC libxl/libvirt_driver_libxl_impl_la-libxl_migration.lo
CCLD libvirt_xenconfig_libxl.la
CC lxc/libvirt_driver_lxc_impl_la-lxc_monitor_protocol.lo
CC lxc/libvirt_driver_lxc_impl_la-lxc_conf.lo
../../src/qemu/qemu_driver.c: In function 'qemuDomainSnapshotCreateXML':
../../src/qemu/qemu_driver.c:15389:26: error: potential null pointer dereference
[-Werror=null-dereference]
bool memory = snapdef->memory == VIR_DOMAIN_SNAPSHOT_LOCATION_EXTERNAL;
~~~~~~~^~~~~~~~
../../src/qemu/qemu_driver.c:15389:26: error: potential null pointer dereference
[-Werror=null-dereference]
In file included from ../../src/util/virbuffer.h:27,
from ../../src/conf/capabilities.h:27,
from ../../src/conf/domain_conf.h:32,
from ../../src/qemu/qemu_agent.h:26,
from ../../src/qemu/qemu_driver.c:40:
../../src/util/viralloc.h:125:34: error: potential null pointer dereference
[-Werror=null-dereference]
# define VIR_ALLOC_N(ptr, count) virAllocN(&(ptr), sizeof(*(ptr)), (count), true, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
VIR_FROM_THIS, __FILE__, __FUNCTION__,
__LINE__)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/qemu/qemu_driver.c:15103:9: note: in expansion of macro 'VIR_ALLOC_N'
if (VIR_ALLOC_N(ret, snapdef->ndisks) < 0)
^~~~~~~~~~~
../../src/qemu/qemu_driver.c:15798:45: error: null pointer dereference
[-Werror=null-dereference]
virDomainSnapshotObjGetDef(snap)->memory ==
VIR_DOMAIN_SNAPSHOT_LOCATION_EXTERNAL) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
cc1: all warnings being treated as errors
gmake[3]: *** [Makefile:10699: qemu/libvirt_driver_qemu_impl_la-qemu_driver.lo] Error 1
gmake[3]: *** Waiting for unfinished jobs....
rm util/virkeycode-xtkbd.pod util/virkeycode-atset3.pod util/virkeycode-qnum.pod
util/virkeycode-win32.pod util/virkeyname-linux.pod util/virkeycode-osx.pod
util/virkeycode-linux.pod util/virkeyname-osx.pod util/virkeyname-win32.pod
util/virkeycode-usb.pod util/virkeycode-atset2.pod util/virkeycode-atset1.pod
gmake[3]: Leaving directory
'<https://ci.centos.org/job/libvirt-build/systems=libvirt-fedora-28/ws/build/src'>
gmake[2]: *** [Makefile:6572: all] Error 2
gmake[2]: Leaving directory
'<https://ci.centos.org/job/libvirt-build/systems=libvirt-fedora-28/ws/build/src'>
gmake[1]: *** [Makefile:2129: all-recursive] Error 1
gmake[1]: Leaving directory
'<https://ci.centos.org/job/libvirt-build/systems=libvirt-fedora-28/ws/build'>
gmake: *** [Makefile:2022: all] Error 2
Build step 'Execute shell' marked build as failure