3:33 a.m.
Hi,
We are making a review of the Japanese messages.
And we fix Japanese help messages first.
Signed-off-by:
Saori Fukuta <fukuta.saori(a)jp.fujitsu.com>,
Minoru Takata <takata.minoru(a)jp.fujitsu.com>
Best regards,
Saori Fukuta
Minoru Takata
3:47 a.m.
Saori Fukuta wrote:
Hi,
We are making a review of the Japanese messages.
And we fix Japanese help messages first.
Signed-off-by:
Saori Fukuta <fukuta.saori(a)jp.fujitsu.com>,
Minoru Takata <takata.minoru(a)jp.fujitsu.com>
Looks good to me.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
4:35 a.m.
On Wed, Jun 13, 2007 at 05:33:36PM +0900, Saori Fukuta wrote:
Hi,
We are making a review of the Japanese messages.
And we fix Japanese help messages first.
Hi Saori,
I applied the patch to virsh.c , that's not a problem, thanks.
However for the localization changes, it is a bit more complex:
- I applied the patch to libvirt internal po/po.ja easy
- but the upstream version for po/po.ja is in a different CVS
directory, and your patch didn't fully applied there
In general the correct way to update the localization is to contact
the list of the people doing this (ja(a)li.org I think). I'm copying
Hyu_gabaru Ryu_ichi who made the last updates to the japanese localization
strings so he understand what is going on. You should probably work together
because some of the changes you suggested didn't apply correctly to the
I18N CVS base:
------------------------
Hunk #39 FAILED at 1554.
Hunk #40 FAILED at 1578.
Hunk #41 succeeded at 1583 (offset -10 lines).
Hunk #42 succeeded at 1613 (offset -1 lines).
Hunk #43 FAILED at 1795.
Hunk #44 FAILED at 1816.
6 out of 44 hunks FAILED -- saving rejects to file ja.po.rej
------------------------
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
7:54 p.m.
On Wed, 13 Jun 2007 05:35:48 -0400 Daniel Veillard wrote:
On Wed, Jun 13, 2007 at 05:33:36PM +0900, Saori Fukuta wrote:
> Hi,
>
> We are making a review of the Japanese messages.
> And we fix Japanese help messages first.
Hi Saori,
I applied the patch to virsh.c , that's not a problem, thanks.
However for the localization changes, it is a bit more complex:
- I applied the patch to libvirt internal po/po.ja easy
- but the upstream version for po/po.ja is in a different CVS
directory, and your patch didn't fully applied there
In general the correct way to update the localization is to contact
the list of the people doing this (ja(a)li.org I think). I'm copying
Hyu_gabaru Ryu_ichi who made the last updates to the japanese localization
strings so he understand what is going on. You should probably work together
because some of the changes you suggested didn't apply correctly to the
I18N CVS base:
Hi Daniel,
Thank you for your comment !
I will make contact with him, and work together.
thanks a lot !
Saori
7:59 a.m.
On Wed, Jun 13, 2007 at 05:33:36PM +0900, Saori Fukuta wrote:
Hi,
We are making a review of the Japanese messages.
And we fix Japanese help messages first.
This is slightly wrong:
- fprintf(stdout, " %-15s %s\n", buf,
opt->help);
+ fprintf(stdout, " %-15s %s\n", buf, _(opt->help));
You can't use _ in this scenario - you need to have _N
Regards
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
8:02 p.m.
On Wed, 13 Jun 2007 13:59:14 +0100 "Daniel P. Berrange" wrote:
On Wed, Jun 13, 2007 at 05:33:36PM +0900, Saori Fukuta wrote:
> Hi,
>
> We are making a review of the Japanese messages.
> And we fix Japanese help messages first.
This is slightly wrong:
> - fprintf(stdout, " %-15s %s\n", buf, opt->help);
> + fprintf(stdout, " %-15s %s\n", buf,
_(opt->help));
You can't use _ in this scenario - you need to have _N
Oh, that's right. Thanks for your pointing out and fixing (revision 1.81) !
Thanks,
Saori.
6370
days inactive
6371
days old
5 comments
4 participants
participants (4)
-
Daniel P. Berrange -
Daniel Veillard -
Richard W.M. Jones -
Saori Fukuta