3:36 p.m.
* update docs/drvvbox.html.in to show support for <controller>
* update docs/fomatdomain.html.in to describe autoport behavior in the
vbox driver
Dawid Zamirski (2):
docs: Update vbox driver documentation.
docs: Document autoport behavior in the vbox driver
docs/drvvbox.html.in | 28 +++++++++++++++++++++++++++-
docs/formatdomain.html.in | 5 ++++-
2 files changed, 31 insertions(+), 2 deletions(-)
--
2.14.2
3:36 p.m.
New subject: [libvirt] [PATCH 1/2] docs: Update vbox driver documentation.
* libvirt no longer supports vbox <= 3.x
* update XML definition sample to show how to attach disks to VBOX's SAS
controller and how to change IDE controller model.
* update XML to show how to create RDP display with autoport.
---
docs/drvvbox.html.in | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/docs/drvvbox.html.in b/docs/drvvbox.html.in
index 63f166b24..a56f5db11 100644
--- a/docs/drvvbox.html.in
+++ b/docs/drvvbox.html.in
@@ -5,7 +5,7 @@
<h1>VirtualBox hypervisor driver</h1>
<p>
The libvirt VirtualBox driver can manage any VirtualBox version
- from version 2.2 onwards.
+ from version 4.0 onwards.
</p>
<h2><a id="project">Project Links</a></h2>
@@ -68,6 +68,14 @@ vbox+ssh://user@example.com/session (remote access, SSH tunnelled)
</features>
<devices>
+ <!--Set IDE controller model to PIIX4 (default PIIX3)-->
+ <controller type='ide' model='piix4'/>
+
+ <controller type='scsi' index='0'/>
+
+ <!--VirtualBox SAS Controller-->
+ <controller type='scsi' index='1'
model='lsisas1068'/>
+
<disk type='file' device='cdrom'>
<source file='/home/user/Downloads/slax-6.0.9.iso'/>
<target dev='hdc'/>
@@ -79,6 +87,19 @@ vbox+ssh://user@example.com/session (remote access, SSH tunnelled)
<target dev='hdd'/>
</disk>
+ <!--Attach to the SCSI controller (index=0, default)-->
+ <disk type='file' device='disk'>
+ <source file='/home/user/tmp/vbox2.vdi'/>
+ <target dev='sda' bus='scsi'/>
+ </disk>
+
+ <!--Attach to the SAS controller (index=1)-->
+ <disk type='file' device='disk'>
+ <source file='/home/user/tmp/vbox3.vdi'/>
+ <target dev='sda' bus='scsi'/>
+ <address type='drive' controller='1' bus='0'
target='0' unit='0'/>
+ </disk>
+
<disk type='file' device='floppy'>
<source file='/home/user/tmp/WIN98C.IMG'/>
<target dev='fda'/>
@@ -101,6 +122,11 @@ vbox+ssh://user@example.com/session (remote access, SSH tunnelled)
<mac address='56:16:3e:5d:c7:9e'/>
<model type='82540eM'/>
</interface>
+
+ <graphics type='desktop'/>
+
+ <!--Activate the VRDE server with a port in 3389-3689 range-->
+ <graphics type='rdp' autoport='yes'
multiUser='yes'/>
<sound model='sb16'/>
--
2.14.2
4:05 p.m.
New subject: [libvirt] [PATCH 1/2] docs: Update vbox driver documentation.
On 11/07/2017 04:36 PM, Dawid Zamirski wrote:
* libvirt no longer supports vbox <= 3.x
* update XML definition sample to show how to attach disks to VBOX's SAS
controller and how to change IDE controller model.
* update XML to show how to create RDP display with autoport.
---
docs/drvvbox.html.in | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/docs/drvvbox.html.in b/docs/drvvbox.html.in
index 63f166b24..a56f5db11 100644
--- a/docs/drvvbox.html.in
+++ b/docs/drvvbox.html.in
@@ -5,7 +5,7 @@
<h1>VirtualBox hypervisor driver</h1>
<p>
The libvirt VirtualBox driver can manage any VirtualBox version
- from version 2.2 onwards.
+ from version 4.0 onwards.
Hmmm... we should have changed that as part of commit id '73c6f16ba' or
'ccdf108c'.
Mind if I add a "(<span class="since">since libvirt
3.0.0</span>)" prior
to the end of line?
E.g.:
The libvirt VirtualBox driver can manage any VirtualBox version
from version 4.0 onwards
(<span class="since">since libvirt 3.0.0</span>).
</p>
<h2><a id="project">Project Links</a></h2>
@@ -68,6 +68,14 @@ vbox+ssh://user@example.com/session (remote access, SSH tunnelled)
</features>
<devices>
+ <!--Set IDE controller model to PIIX4 (default PIIX3)-->
+ <controller type='ide' model='piix4'/>
+
+ <controller type='scsi' index='0'/>
+
+ <!--VirtualBox SAS Controller-->
+ <controller type='scsi' index='1'
model='lsisas1068'/>
+
<disk type='file' device='cdrom'>
<source file='/home/user/Downloads/slax-6.0.9.iso'/>
<target dev='hdc'/>
@@ -79,6 +87,19 @@ vbox+ssh://user@example.com/session (remote access, SSH tunnelled)
<target dev='hdd'/>
</disk>
+ <!--Attach to the SCSI controller (index=0, default)-->
+ <disk type='file' device='disk'>
+ <source file='/home/user/tmp/vbox2.vdi'/>
+ <target dev='sda' bus='scsi'/>
+ </disk>
+
+ <!--Attach to the SAS controller (index=1)-->
+ <disk type='file' device='disk'>
+ <source file='/home/user/tmp/vbox3.vdi'/>
+ <target dev='sda' bus='scsi'/>
+ <address type='drive' controller='1' bus='0'
target='0' unit='0'/>
+ </disk>
+
<disk type='file' device='floppy'>
<source file='/home/user/tmp/WIN98C.IMG'/>
<target dev='fda'/>
@@ -101,6 +122,11 @@ vbox+ssh://user@example.com/session (remote access, SSH tunnelled)
<mac address='56:16:3e:5d:c7:9e'/>
<model type='82540eM'/>
</interface>
+
There's some extraneous whitespace above as git am so kindly told me:
Applying: docs: Update vbox driver documentation.
.git/rebase-apply/patch:57: trailing whitespace.
warning: 1 line adds whitespace errors.
I will fix up before pushing...
John
+ <graphics type='desktop'/>
+
+ <!--Activate the VRDE server with a port in 3389-3689 range-->
+ <graphics type='rdp' autoport='yes'
multiUser='yes'/>
<sound model='sb16'/>
4:17 p.m.
New subject: [libvirt] [PATCH 1/2] docs: Update vbox driver documentation.
On Tue, 2017-11-07 at 17:05 -0500, John Ferlan wrote:
On 11/07/2017 04:36 PM, Dawid Zamirski wrote:
> * libvirt no longer supports vbox <= 3.x
> * update XML definition sample to show how to attach disks to
> VBOX's SAS
> controller and how to change IDE controller model.
> * update XML to show how to create RDP display with autoport.
> ---
> docs/drvvbox.html.in | 28 +++++++++++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/docs/drvvbox.html.in b/docs/drvvbox.html.in
> index 63f166b24..a56f5db11 100644
> --- a/docs/drvvbox.html.in
> +++ b/docs/drvvbox.html.in
> @@ -5,7 +5,7 @@
> <h1>VirtualBox hypervisor driver</h1>
> <p>
> The libvirt VirtualBox driver can manage any VirtualBox
> version
> - from version 2.2 onwards.
> + from version 4.0 onwards.
Hmmm... we should have changed that as part of commit id '73c6f16ba'
or
'ccdf108c'.
Mind if I add a "(<span class="since">since libvirt
3.0.0</span>)"
prior
to the end of line?
Sure no problem :-)
E.g.:
The libvirt VirtualBox driver can manage any VirtualBox
version
from version 4.0 onwards
(<span class="since">since libvirt 3.0.0</span>).
> </p>
>
> <h2><a id="project">Project Links</a></h2>
> @@ -68,6 +68,14 @@ vbox+ssh://user@example.com/session (remote
> access, SSH tunnelled)
> </features>
>
> <devices>
> + <!--Set IDE controller model to PIIX4 (default PIIX3)-->
> + <controller type='ide' model='piix4'/>
> +
> + <controller type='scsi' index='0'/>
> +
> + <!--VirtualBox SAS Controller-->
> + <controller type='scsi' index='1'
model='lsisas1068'/>
> +
> <disk type='file' device='cdrom'>
> <source file='/home/user/Downloads/slax-6.0.9.iso'/>
> <target dev='hdc'/>
> @@ -79,6 +87,19 @@ vbox+ssh://user@example.com/session (remote
> access, SSH tunnelled)
> <target dev='hdd'/>
> </disk>
>
> + <!--Attach to the SCSI controller (index=0, default)-->
> + <disk type='file' device='disk'>
> + <source file='/home/user/tmp/vbox2.vdi'/>
> + <target dev='sda' bus='scsi'/>
> + </disk>
> +
> + <!--Attach to the SAS controller (index=1)-->
> + <disk type='file' device='disk'>
> + <source file='/home/user/tmp/vbox3.vdi'/>
> + <target dev='sda' bus='scsi'/>
> + <address type='drive' controller='1' bus='0'
target='0'
> unit='0'/>
> + </disk>
> +
> <disk type='file' device='floppy'>
> <source file='/home/user/tmp/WIN98C.IMG'/>
> <target dev='fda'/>
> @@ -101,6 +122,11 @@ vbox+ssh://user@example.com/session (remote
> access, SSH tunnelled)
> <mac address='56:16:3e:5d:c7:9e'/>
> <model type='82540eM'/>
> </interface>
> +
There's some extraneous whitespace above as git am so kindly told me:
Applying: docs: Update vbox driver documentation.
.git/rebase-apply/patch:57: trailing whitespace.
warning: 1 line adds whitespace errors.
I will fix up before pushing...
John
> + <graphics type='desktop'/>
> +
> + <!--Activate the VRDE server with a port in 3389-3689
> range-->
> + <graphics type='rdp' autoport='yes'
multiUser='yes'/>
>
> <sound model='sb16'/>
>
>
3:36 p.m.
New subject: [libvirt] [PATCH 2/2] docs: Document autoport behavior in the vbox driver
---
docs/formatdomain.html.in | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 92e14a919..d3cabac44 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -6100,7 +6100,10 @@ qemu-kvm -net nic,model=? /dev/null
TCP port number (with -1 as legacy syntax indicating that it should
be auto-allocated). The <code>autoport</code> attribute is the
new
preferred syntax for indicating auto-allocation of the TCP port to
- use. The <code>multiUser</code> attribute is a boolean
deciding
+ use. In the VirtualBox driver, the <code>autoport</code> will
make
+ the hypervisor pick available port from 3389-3689 range when the VM
+ is started. The chosen port will be reflected in the
<code>port</code>
+ attribute. The <code>multiUser</code> attribute is a boolean
deciding
whether multiple simultaneous connections to the VM are permitted.
The <code>replaceUser</code> attribute is a boolean deciding
whether
the existing connection must be dropped and a new connection must
--
2.14.2
4:06 p.m.
On 11/07/2017 04:36 PM, Dawid Zamirski wrote:
* update docs/drvvbox.html.in to show support for <controller>
* update docs/fomatdomain.html.in to describe autoport behavior in the
vbox driver
Dawid Zamirski (2):
docs: Update vbox driver documentation.
docs: Document autoport behavior in the vbox driver
docs/drvvbox.html.in | 28 +++++++++++++++++++++++++++-
docs/formatdomain.html.in | 5 ++++-
2 files changed, 31 insertions(+), 2 deletions(-)
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
(series)
I'll push once I get feedback from you regarding patch 1 question.
John
2572
days inactive
2572
days old
5 comments
2 participants
participants (2)
-
Dawid Zamirski -
John Ferlan