Re: [Libvirt-cim] [PATCH] [TEST] Fix none value for disk assigned for Xen

libvirt-cim-bounces(a)redhat.com wrote on 2009-01-14 04:35:35: > >> + + if virt == 'LXC': > >> d = class_dasd(disk_dev, disk_source, dom_name) > >> - + else: > >> + # Xen's case falls in here using the default values > >> + d = class_dasd(disk_dev, disk_source, dom_name, emu_type) > > +1 , but make sure next time we align the comments with the block properly. > >> class_masd = get_masd_class(virt) > >> m = class_masd( > >> megabytes=mem_mb, > >> > > The above function call should be aligned as follows. > > m = class_masd(megabytes=mem_mb, > > mallocunits=malloc_units, > > name=dom_name) > > I agree with these comments. Daisy - can you resend the patch with > these updates? I think it's better to align them as follows: m = class_masd(megabytes=mem_mb, mallocunits=malloc_units, name=dom_name) Also, the other functions such as network and processor call have to be updated. I resend a new patch to fix them. Thanks! > > Thanks! > -- > Kaitlin Rupert > IBM Linux Technology Center > kaitlin(a)linux.vnet.ibm.com > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvirt-cim ------------------------------------------------------------------------ _______________________________________________ Libvirt-cim mailing list Libvirt-cim(a)redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim