[libvirt] [PATCH] Allow RO connections to interface udev backend
The udev based interface backend did not allow querying data over a read-only connection which is different than how the netcf backend operates. This brings the behavior inline with the default, netcf backend. --- src/interface/interface_backend_udev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index 68e1e2f..95034bf 100644 --- a/src/interface/interface_backend_udev.c +++ b/src/interface/interface_backend_udev.c @@ -139,7 +139,7 @@ udevInterfaceOpen(virConnectPtr conn, { struct udev_iface_driver *driverState = NULL; - virCheckFlags(0, VIR_DRV_OPEN_ERROR); + virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); if (VIR_ALLOC(driverState) < 0) { virReportOOMError(); -- 1.8.1.5
On 06/28/2013 03:48 AM, Doug Goldstein wrote:
The udev based interface backend did not allow querying data over a read-only connection which is different than how the netcf backend operates. This brings the behavior inline with the default, netcf backend. --- src/interface/interface_backend_udev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK Jan
On Fri, Jun 28, 2013 at 2:49 AM, Ján Tomko <jtomko@redhat.com> wrote:
On 06/28/2013 03:48 AM, Doug Goldstein wrote:
The udev based interface backend did not allow querying data over a read-only connection which is different than how the netcf backend operates. This brings the behavior inline with the default, netcf backend. --- src/interface/interface_backend_udev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Jan
Ok to push for 1.1.0? This really should be included IMHO to unbreak the API. -- Doug Goldstein
On Fri, Jun 28, 2013 at 06:43:37AM -0500, Doug Goldstein wrote:
On Fri, Jun 28, 2013 at 2:49 AM, Ján Tomko <jtomko@redhat.com> wrote:
On 06/28/2013 03:48 AM, Doug Goldstein wrote:
The udev based interface backend did not allow querying data over a read-only connection which is different than how the netcf backend operates. This brings the behavior inline with the default, netcf backend. --- src/interface/interface_backend_udev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Jan
Ok to push for 1.1.0? This really should be included IMHO to unbreak the API.
ACK Minimal risk, so fine to push. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (3)
-
Daniel P. Berrange -
Doug Goldstein -
Ján Tomko