On 06/25/2014 01:18 PM, Eric Blake wrote:

On 06/25/2014 11:08 AM, Scott Sullivan wrote:

...

I am trying to build v1.2.5-maint, however I have one test failing causing the build to fail:

TEST: securityselinuxlabeltest !!!. 4 FAIL

Can you rerun this to give more details on the failure:

make -C tests check TESTS=securityselinuxlabeltest VIR_TEST_DEBUG=1

Thanks for the help. Here's the requested output: -bash-4.1$ make -C tests check TESTS=securityselinuxlabeltest VIR_TEST_DEBUG=1 make: Entering directory `/home/rpmbuild/packages/libvirt/tests' make libshunload.la libvirportallocatormock.la virnetserverclientmock.la vircgroupmock.la virpcimock.la libqemumonitortestutils.la qemuxml2argvmock.la virusbmock.la libsecurityselinuxhelper.la virshtest sockettest nodeinfotest virbuftest commandtest seclabeltest virhashtest viratomictest utiltest shunloadtest vir timetest viruritest virkeyfiletest viralloctest virauthconfigtest virbitmaptest vircgrouptest vircryptotest virpcitest virendiantest virfiletest virfirewalltest viriscsitest virkeycodetest virlockspacetest virlogtest virstringtest virportallocatortest sysinfotest virstoragetest virnetdevbandwidthtest virkmodtest virca pstest domainconftest virhostdevtest virnetmessagetest virnetsockettest virnetserverclienttest virnettlscontexttest virnettlssessiontest fchosttest fdstreamtest securityselinuxtest viridentitytest securityselinuxlabeltest virdrivermoduletest qemuxml2argvtest qemuxml2xmltest qemuxmlnstest qemuargv2xmltest qemuhelptes t domainsnapshotxml2xmltest qemumonitortest qemumonitorjsontest qemuhotplugtest qemuagenttest qemucapabilitiestest qemucaps2xmltest lxcxml2xmltest lxcconf2xmltest openvzutilstest esxutilstest vmx2xmltest xml2vmxtest vmwarevertest jsontest networkxml2xmltest networkxml2xmlupdatetest networkxml2conftest networkxml2fir ewalltest nwfilterxml2xmltest nwfilterebiptablestest nwfilterxml2firewalltest storagevolxml2argvtest virscsitest storagevolxml2xmltest storagepoolxml2xmltest nodedevxml2xmltest interfacexml2xmltest cputest metadatatest secretxml2xmltest virusbtest eventtest libvirtdconftest objecteventtest commandhelper ssh test_conf make[1]: Entering directory `/home/rpmbuild/packages/libvirt/tests' make[1]: `libshunload.la' is up to date. make[1]: `libvirportallocatormock.la' is up to date. make[1]: `virnetserverclientmock.la' is up to date. make[1]: `vircgroupmock.la' is up to date. make[1]: `virpcimock.la' is up to date. make[1]: `libqemumonitortestutils.la' is up to date. make[1]: `qemuxml2argvmock.la' is up to date. make[1]: `virusbmock.la' is up to date. make[1]: `libsecurityselinuxhelper.la' is up to date. make[1]: `virshtest' is up to date. make[1]: `sockettest' is up to date. make[1]: `nodeinfotest' is up to date. make[1]: `virbuftest' is up to date. make[1]: `commandtest' is up to date. make[1]: `seclabeltest' is up to date. make[1]: `virhashtest' is up to date. make[1]: `viratomictest' is up to date. make[1]: `utiltest' is up to date. make[1]: `shunloadtest' is up to date. make[1]: `virtimetest' is up to date. make[1]: `viruritest' is up to date. make[1]: `virkeyfiletest' is up to date. make[1]: `viralloctest' is up to date. make[1]: `virauthconfigtest' is up to date. make[1]: `virbitmaptest' is up to date. make[1]: `vircgrouptest' is up to date. make[1]: `vircryptotest' is up to date. make[1]: `virpcitest' is up to date. make[1]: `virendiantest' is up to date. make[1]: `virfiletest' is up to date. make[1]: `virfirewalltest' is up to date. make[1]: `viriscsitest' is up to date. make[1]: `virkeycodetest' is up to date. make[1]: `virlockspacetest' is up to date. make[1]: `virlogtest' is up to date. make[1]: `virstringtest' is up to date. make[1]: `virportallocatortest' is up to date. make[1]: `sysinfotest' is up to date. make[1]: `virstoragetest' is up to date. make[1]: `virnetdevbandwidthtest' is up to date. make[1]: `virkmodtest' is up to date. make[1]: `vircapstest' is up to date. make[1]: `domainconftest' is up to date. make[1]: `virhostdevtest' is up to date. make[1]: `virnetmessagetest' is up to date. make[1]: `virnetsockettest' is up to date. make[1]: `virnetserverclienttest' is up to date. make[1]: `virnettlscontexttest' is up to date. make[1]: `virnettlssessiontest' is up to date. make[1]: `fchosttest' is up to date. make[1]: `fdstreamtest' is up to date. make[1]: `securityselinuxtest' is up to date. make[1]: `viridentitytest' is up to date. make[1]: `securityselinuxlabeltest' is up to date. make[1]: `virdrivermoduletest' is up to date. make[1]: `qemuxml2argvtest' is up to date. make[1]: `qemuxml2xmltest' is up to date. make[1]: `qemuxmlnstest' is up to date. make[1]: `qemuargv2xmltest' is up to date. make[1]: `qemuhelptest' is up to date. make[1]: `domainsnapshotxml2xmltest' is up to date. make[1]: `qemumonitortest' is up to date. make[1]: `qemumonitorjsontest' is up to date. make[1]: `qemuhotplugtest' is up to date. make[1]: `qemuagenttest' is up to date. make[1]: `qemucapabilitiestest' is up to date. make[1]: `qemucaps2xmltest' is up to date. make[1]: `lxcxml2xmltest' is up to date. make[1]: `lxcconf2xmltest' is up to date. make[1]: `openvzutilstest' is up to date. make[1]: `esxutilstest' is up to date. make[1]: `vmx2xmltest' is up to date. make[1]: `xml2vmxtest' is up to date. make[1]: `vmwarevertest' is up to date. make[1]: `jsontest' is up to date. make[1]: `networkxml2xmltest' is up to date. make[1]: `networkxml2xmlupdatetest' is up to date. make[1]: `networkxml2conftest' is up to date. make[1]: `networkxml2firewalltest' is up to date. make[1]: `nwfilterxml2xmltest' is up to date. make[1]: `nwfilterebiptablestest' is up to date. make[1]: `nwfilterxml2firewalltest' is up to date. make[1]: `storagevolxml2argvtest' is up to date. make[1]: `virscsitest' is up to date. make[1]: `storagevolxml2xmltest' is up to date. make[1]: `storagepoolxml2xmltest' is up to date. make[1]: `nodedevxml2xmltest' is up to date. make[1]: `interfacexml2xmltest' is up to date. make[1]: `cputest' is up to date. make[1]: `metadatatest' is up to date. make[1]: `secretxml2xmltest' is up to date. make[1]: `virusbtest' is up to date. make[1]: `eventtest' is up to date. make[1]: `libvirtdconftest' is up to date. make[1]: `objecteventtest' is up to date. make[1]: `commandhelper' is up to date. make[1]: `ssh' is up to date. make[1]: `test_conf' is up to date. make[1]: Leaving directory `/home/rpmbuild/packages/libvirt/tests' make check-TESTS make[1]: Entering directory `/home/rpmbuild/packages/libvirt/tests' TEST: securityselinuxlabeltest QEMU driver capabilities: <capabilities> <host> <cpu> <arch>x86_64</arch> <model>core2duo</model> <vendor>Intel</vendor> <topology sockets='1' cores='2' threads='1'/> <feature name='lahf_lm'/> <feature name='xtpr'/> <feature name='cx16'/> <feature name='tm2'/> <feature name='est'/> <feature name='vmx'/> <feature name='ds_cpl'/> <feature name='pbe'/> <feature name='tm'/> <feature name='ht'/> <feature name='ss'/> <feature name='acpi'/> <feature name='ds'/> </cpu> <power_management/> </host> <guest> <os_type>hvm</os_type> <arch name='i686'> <wordsize>32</wordsize> <emulator>/usr/bin/qemu</emulator> <machine>pc</machine> <machine>isapc</machine> <domain type='qemu'> </domain> </arch> <features> <cpuselection/> </features> </guest> <guest> <os_type>hvm</os_type> <arch name='x86_64'> <wordsize>64</wordsize> <emulator>/usr/bin/qemu-system-x86_64</emulator> <machine>pc-0.11</machine> <machine canonical='pc-0.11'>pc</machine> <machine>pc-0.10</machine> <machine>isapc</machine> <domain type='qemu'> </domain> <domain type='kvm'> <emulator>/usr/bin/kvm</emulator> <machine>pc</machine> <machine>isapc</machine> </domain> </arch> <features> <cpuselection/> </features> </guest> <guest> <os_type>xen</os_type> <arch name='x86_64'> <wordsize>64</wordsize> <emulator>/usr/bin/xenner</emulator> <machine>xenner</machine> <domain type='kvm'> <emulator>/usr/bin/kvm</emulator> </domain> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name='ppc64'> <wordsize>64</wordsize> <emulator>/usr/bin/qemu-system-ppc64</emulator> <machine>pseries</machine> <domain type='qemu'> </domain> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name='ppc'> <wordsize>32</wordsize> <emulator>/usr/bin/qemu-system-ppc</emulator> <machine>g3beige</machine> <domain type='qemu'> </domain> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name='s390x'> <wordsize>64</wordsize> <emulator>/usr/bin/qemu-system-s390x</emulator> <machine>s390-virtio</machine> <machine>s390-ccw-virtio</machine> <domain type='qemu'> </domain> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name='armv7l'> <wordsize>32</wordsize> <emulator>/usr/bin/qemu-system-arm</emulator> <machine>vexpress-a9</machine> <machine>vexpress-a15</machine> <machine>versatilepb</machine> <domain type='qemu'> </domain> </arch> </guest> <guest> <os_type>hvm</os_type> <arch name='aarch64'> <wordsize>64</wordsize> <emulator>/usr/bin/qemu-system-aarch64</emulator> <machine>virt</machine> <domain type='qemu'> </domain> </arch> </guest> </capabilities> 1) Labelling "disks" ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.raw context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' libvirt: error : internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.raw context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' FAILED 2) Labelling "kernel" ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/vmlinuz.raw context 'EOPNOTSUPP' did not match epected 'system_u:object_r:virt_content_t:s0' libvirt: error : internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/vmlinuz.raw context 'EOPNOTSUPP' did not match epected 'system_u:object_r:virt_content_t:s0' FAILED 3) Labelling "chardev" ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.txt context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' libvirt: error : internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.txt context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' FAILED 4) Labelling "nfs" ... OK FAIL: securityselinuxlabeltest ======================================= 1 of 1 test failed Please report to libvir-list@redhat.com ======================================= make[1]: *** [check-TESTS] Error 1 make[1]: Leaving directory `/home/rpmbuild/packages/libvirt/tests' make: *** [check-am] Error 2 make: Leaving directory `/home/rpmbuild/packages/libvirt/tests' -bash-4.1$

...

Is anyone else having this problem? Im building on CentOS 6.5. Im happy to provide any further information as needed. It's passing for me on my RHEL 6.5 box from libvirt.git master branch, so I'm not sure what is different between our environments.

I do have selinux disabled if that's a possible factor. -bash-4.1$ sestatus SELinux status: disabled -bash-4.1$

On 06/26/2014 10:09 AM, Ján Tomko wrote:

On 06/26/2014 03:56 PM, Scott Sullivan wrote:

...

1) Labelling "disks" ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.raw context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' libvirt: error : internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.raw context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' FAILED 2) Labelling "kernel" ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/vmlinuz.raw context 'EOPNOTSUPP' did not match epected 'system_u:object_r:virt_content_t:s0' libvirt: error : internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/vmlinuz.raw context 'EOPNOTSUPP' did not match epected 'system_u:object_r:virt_content_t:s0' FAILED 3) Labelling "chardev" ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.txt context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' libvirt: error : internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.txt context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' FAILED 4) Labelling "nfs" ... OK FAIL: securityselinuxlabeltest There was a patch skipping the test if setting xattrs is not supported, but it's not merged yet:

https://www.redhat.com/archives/libvir-list/2014-June/msg00402.html

Jan

Jan, Thanks for this. I've applied the patch and it has solved my issues. Thanks again.

On 06/26/2014 05:36 PM, Eric Blake wrote:

On 06/26/2014 09:38 AM, Scott Sullivan wrote:

...

On 06/26/2014 10:09 AM, Ján Tomko wrote:

...

On 06/26/2014 03:56 PM, Scott Sullivan wrote:

...

1) Labelling "disks" ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.raw context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' There was a patch skipping the test if setting xattrs is not supported, but it's not merged yet:

https://www.redhat.com/archives/libvir-list/2014-June/msg00402.html

Jan

Jan,

Thanks for this. I've applied the patch and it has solved my issues. Now pushed; it missed 1.2.6-rc1, but should be in rc2, if you want to test that in a couple days.

Hi Eric. I've tested the v1.2.6-rc2 git tag, im getting this build error: CC util/libvirt_util_la-virnuma.lo util/virnuma.c: In function 'virNumaNodeIsAvailable': util/virnuma.c:428: error: 'numa_nodes_ptr' undeclared (first use in this function) util/virnuma.c:428: error: (Each undeclared identifier is reported only once util/virnuma.c:428: error: for each function it appears in.) make[3]: *** [util/libvirt_util_la-virnuma.lo] Error 1 make[3]: Leaving directory `/home/rpmbuild/packages/libvirt/src' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/rpmbuild/packages/libvirt/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/rpmbuild/packages/libvirt' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.3Gu7nd (%build) Build works fine on tag v1.2.5-maint.

On Mon, Jun 30, 2014 at 03:26:07PM -0600, Eric Blake wrote:

On 06/30/2014 01:46 PM, Scott Sullivan wrote:

...

I've tested the v1.2.6-rc2 git tag, im getting this build error:

CC util/libvirt_util_la-virnuma.lo util/virnuma.c: In function 'virNumaNodeIsAvailable': util/virnuma.c:428: error: 'numa_nodes_ptr' undeclared (first use in this function) util/virnuma.c:428: error: (Each undeclared identifier is reported only once util/virnuma.c:428: error: for each function it appears in.)

What version of numactl-devel do you have installed?

...

make[3]: *** [util/libvirt_util_la-virnuma.lo] Error 1 make[3]: Leaving directory `/home/rpmbuild/packages/libvirt/src' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/rpmbuild/packages/libvirt/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/rpmbuild/packages/libvirt' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.3Gu7nd (%build)

Build works fine on tag v1.2.5-maint.

Sounds like we need to make code added in the meantime be conditional to compile to older numa libraries.

Guess we have to check for numa_nodes_ptr in the conditional for HAVE_NUMA_BITMASK_ISBITSET, but that's definitely some odd version of numactl. Martin

HI The issue still exists if the upstream src is built on RH 6.x. After numactl and numactl-devel is upgraded to 2.0.9, the issue gets fixed. On Tue, Jul 1, 2014 at 5:26 AM, Eric Blake <eblake@redhat.com> wrote:

On 06/30/2014 01:46 PM, Scott Sullivan wrote:

...

I've tested the v1.2.6-rc2 git tag, im getting this build error:

CC util/libvirt_util_la-virnuma.lo util/virnuma.c: In function 'virNumaNodeIsAvailable': util/virnuma.c:428: error: 'numa_nodes_ptr' undeclared (first use in this function) util/virnuma.c:428: error: (Each undeclared identifier is reported only once util/virnuma.c:428: error: for each function it appears in.)

What version of numactl-devel do you have installed?

...

make[3]: *** [util/libvirt_util_la-virnuma.lo] Error 1 make[3]: Leaving directory `/home/rpmbuild/packages/libvirt/src' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/rpmbuild/packages/libvirt/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/rpmbuild/packages/libvirt' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.3Gu7nd (%build)

Build works fine on tag v1.2.5-maint.

Sounds like we need to make code added in the meantime be conditional to compile to older numa libraries.

-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

-- Regards, Zhi Yong Wu

On 06/26/2014 11:38 PM, Scott Sullivan wrote:

On 06/26/2014 10:09 AM, Ján Tomko wrote:

...

On 06/26/2014 03:56 PM, Scott Sullivan wrote:

...

1) Labelling "disks" ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.raw

context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' libvirt: error : internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.raw

context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' FAILED 2) Labelling "kernel" ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/vmlinuz.raw

context 'EOPNOTSUPP' did not match epected 'system_u:object_r:virt_content_t:s0' libvirt: error : internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/vmlinuz.raw

context 'EOPNOTSUPP' did not match epected 'system_u:object_r:virt_content_t:s0' FAILED 3) Labelling "chardev" ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.txt

context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' libvirt: error : internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.txt

context 'EOPNOTSUPP' did not match epected 'system_u:object_r:svirt_image_t:s0:c41,c264' FAILED 4) Labelling "nfs" ... OK FAIL: securityselinuxlabeltest There was a patch skipping the test if setting xattrs is not supported, but it's not merged yet:

https://www.redhat.com/archives/libvir-list/2014-June/msg00402.html

Jan

Jan,

Thanks for this. I've applied the patch and it has solved my issues.

Hi Scott, Because this patch is only for compatibilities for the old kernel, and it skips the securityselinuxlabeltest, the better way is to upgrade to the kernel that default to support xattr in its filesystem, or remount the currently filesystem with xattr, for ext4: # mount -o acl,user_xattr /dev/sda1 /mount/point or add one line to /etc/mtab /dev/sda1 /mount/point ext4 rw,acl,user_xattr 0 0 Best wishes, Jincheng Miao

Thanks again.

-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list