12:43 p.m.
Syncing changes back from Fedora to follow best practice
Daniel P. Berrangé (6):
Remove obsolete RPM group tag
Replace search.cpan.org with metacpan.org
Remove commented out cruft leftover from Module::Build conversion
Remove obsolete %defattr statement
Use %license for LICENSE file instead of %doc
Modernize list of build deps to match actual required packages
perl-Sys-Virt.spec.PL | 45 ++++++++++++++++++++++++++++---------------
1 file changed, 30 insertions(+), 15 deletions(-)
--
2.17.0
12:43 p.m.
New subject: [libvirt] [perl PATCH 1/6] Remove obsolete RPM group tag
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 1 -
1 file changed, 1 deletion(-)
diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL
index e7b4044..b171826 100644
--- a/perl-Sys-Virt.spec.PL
+++ b/perl-Sys-Virt.spec.PL
@@ -31,7 +31,6 @@ Version: @VERSION@
Release: 1%{?dist}
Summary: Represent and manage a libvirt hypervisor connection
License: GPLv2+ or Artistic
-Group: Development/Libraries
URL: http://search.cpan.org/dist/Sys-Virt/
Source0: http://www.cpan.org/authors/id/D/DA/DANBERR/Sys-Virt-v%{version}.tar.gz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
--
2.17.0
1:29 p.m.
New subject: [libvirt] [perl PATCH 1/6] Remove obsolete RPM group tag
On Tue, Jun 05, 2018 at 06:43:56PM +0100, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
12:43 p.m.
New subject: [libvirt] [perl PATCH 2/6] Replace search.cpan.org with metacpan.org
The former is being shutdown very soon in favour of the latter
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL
index b171826..928c7cf 100644
--- a/perl-Sys-Virt.spec.PL
+++ b/perl-Sys-Virt.spec.PL
@@ -31,8 +31,8 @@ Version: @VERSION@
Release: 1%{?dist}
Summary: Represent and manage a libvirt hypervisor connection
License: GPLv2+ or Artistic
-URL: http://search.cpan.org/dist/Sys-Virt/
-Source0: http://www.cpan.org/authors/id/D/DA/DANBERR/Sys-Virt-v%{version}.tar.gz
+URL: https://metacpan.org/release/Sys-Virt
+Source0:
https://cpan.metacpan.org/authors/id/D/DA/DANBERR/Sys-Virt-v%{version}.ta...
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires: perl(ExtUtils::CBuilder)
BuildRequires: perl(Module::Build)
--
2.17.0
1:29 p.m.
New subject: [libvirt] [perl PATCH 2/6] Replace search.cpan.org with metacpan.org
On Tue, Jun 05, 2018 at 06:43:57PM +0100, Daniel P. Berrangé wrote:
The former is being shutdown very soon in favour of the latter
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
12:43 p.m.
New subject: [libvirt] [perl PATCH 3/6] Remove commented out cruft leftover from Module::Build conversion
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 4 ----
1 file changed, 4 deletions(-)
diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL
index 928c7cf..341e40c 100644
--- a/perl-Sys-Virt.spec.PL
+++ b/perl-Sys-Virt.spec.PL
@@ -60,10 +60,6 @@ virtualization containers to be managed with a consistent API.
%install
./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-#find $RPM_BUILD_ROOT -type f \( -name .packlist -o -name '*.bs' -empty \) |
-# xargs rm -f
-#find $RPM_BUILD_ROOT -depth -type d -empty -exec rmdir {} \;
-
%{_fixperms} $RPM_BUILD_ROOT/*
%check
--
2.17.0
1:29 p.m.
New subject: [libvirt] [perl PATCH 3/6] Remove commented out cruft leftover from Module::Build conversion
On Tue, Jun 05, 2018 at 06:43:58PM +0100, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 4 ----
1 file changed, 4 deletions(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
12:43 p.m.
New subject: [libvirt] [perl PATCH 4/6] Remove obsolete %defattr statement
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 1 -
1 file changed, 1 deletion(-)
diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL
index 341e40c..35f8e01 100644
--- a/perl-Sys-Virt.spec.PL
+++ b/perl-Sys-Virt.spec.PL
@@ -66,7 +66,6 @@ virtualization containers to be managed with a consistent API.
./Build test
%files
-%defattr(-,root,root,-)
%doc AUTHORS Changes LICENSE README examples/
%{perl_vendorarch}/auto/*
%{perl_vendorarch}/Sys*
--
2.17.0
1:30 p.m.
New subject: [libvirt] [perl PATCH 4/6] Remove obsolete %defattr statement
On Tue, Jun 05, 2018 at 06:43:59PM +0100, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
12:44 p.m.
New subject: [libvirt] [perl PATCH 5/6] Use %license for LICENSE file instead of %doc
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL
index 35f8e01..dd26412 100644
--- a/perl-Sys-Virt.spec.PL
+++ b/perl-Sys-Virt.spec.PL
@@ -66,7 +66,8 @@ virtualization containers to be managed with a consistent API.
./Build test
%files
-%doc AUTHORS Changes LICENSE README examples/
+%license LICENSE
+%doc AUTHORS Changes README examples/
%{perl_vendorarch}/auto/*
%{perl_vendorarch}/Sys*
%{_mandir}/man3/*
--
2.17.0
1:30 p.m.
New subject: [libvirt] [perl PATCH 5/6] Use %license for LICENSE file instead of %doc
On Tue, Jun 05, 2018 at 06:44:00PM +0100, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
12:44 p.m.
New subject: [libvirt] [perl PATCH 6/6] Modernize list of build deps to match actual required packages
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 32 ++++++++++++++++++++++++++------
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL
index dd26412..451af27 100644
--- a/perl-Sys-Virt.spec.PL
+++ b/perl-Sys-Virt.spec.PL
@@ -34,15 +34,35 @@ License: GPLv2+ or Artistic
URL: https://metacpan.org/release/Sys-Virt
Source0:
https://cpan.metacpan.org/authors/id/D/DA/DANBERR/Sys-Virt-v%{version}.ta...
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+# Build
+BuildRequires: coreutils
+BuildRequires: findutils
+BuildRequires: gcc
+BuildRequires: libvirt-devel >= %{version}
+BuildRequires: make
+BuildRequires: perl-interpreter
+BuildRequires: perl-devel
+BuildRequires: perl-generators
BuildRequires: perl(ExtUtils::CBuilder)
BuildRequires: perl(Module::Build)
-BuildRequires: perl(Test::Pod)
-BuildRequires: perl(Test::Pod::Coverage)
-BuildRequires: perl(Test::CPAN::Changes)
-BuildRequires: perl(XML::XPath)
+BuildRequires: sed
+# Runtime
+BuildRequires: perl(overload)
+BuildRequires: perl(strict)
+BuildRequires: perl(warnings)
+BuildRequires: perl(XSLoader)
+# Tests only
+BuildRequires: perl(base)
+BuildRequires: perl(Sys::Hostname)
+BuildRequires: perl(Test::More)
BuildRequires: perl(Time::HiRes)
-BuildRequires: libvirt-devel >= %{version}
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+BuildRequires: perl(XML::XPath)
+BuildRequires: perl(XML::XPath::XMLParser)
+# Optional tests only
+BuildRequires: perl(Test::CPAN::Changes)
+BuildRequires: perl(Test::Pod) >= 1.00
+BuildRequires: perl(Test::Pod::Coverage) >= 1.00
+Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo
$version))
%description
The Sys::Virt module provides a Perl XS binding to the libvirt virtual
--
2.17.0
1:32 p.m.
New subject: [libvirt] [perl PATCH 6/6] Modernize list of build deps to match actual required packages
On Tue, Jun 05, 2018 at 06:44:01PM +0100, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
perl-Sys-Virt.spec.PL | 32 ++++++++++++++++++++++++++------
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL
index dd26412..451af27 100644
--- a/perl-Sys-Virt.spec.PL
+++ b/perl-Sys-Virt.spec.PL
@@ -34,15 +34,35 @@ License: GPLv2+ or Artistic
URL: https://metacpan.org/release/Sys-Virt
Source0:
https://cpan.metacpan.org/authors/id/D/DA/DANBERR/Sys-Virt-v%{version}.ta...
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+# Build
+BuildRequires: coreutils
The core isn't what it used to be...
+BuildRequires: findutils
+BuildRequires: gcc
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
2327
days inactive
2327
days old
12 comments
2 participants
participants (2)
-
Daniel P. Berrangé -
Ján Tomko