[libvirt] [PATCH] util:Fix with process number and pid file do not match
Bobo Du (1): util:Fix with process number and pid file do not match src/util/virpidfile.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 1.8.3.1
the libvirtd pid file is not match the os process pid number which is smaller than before. this would be exist if the libvirtd process coredump or the os process was killed which the next pid number is smaller. you can be also edit the pid file to write the longer number than before,then restart the libvirtd service. Signed-off-by: Bobo Du <dubo163@126.com> --- src/util/virpidfile.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/util/virpidfile.c b/src/util/virpidfile.c index 58ab29f..1a85d43 100644 --- a/src/util/virpidfile.c +++ b/src/util/virpidfile.c @@ -446,6 +446,14 @@ int virPidFileAcquirePath(const char *path, snprintf(pidstr, sizeof(pidstr), "%lld", (long long) pid); + if (ftruncate(fd, 0) < 0) { + virReportSystemError(errno, + _("Failed to truncate pid file '%s'"), + path); + VIR_FORCE_CLOSE(fd); + return -1; + } + if (safewrite(fd, pidstr, strlen(pidstr)) < 0) { virReportSystemError(errno, _("Failed to write to pid file '%s'"), -- 1.8.3.1
On 07/04/2018 05:55 AM, Bobo Du wrote:
the libvirtd pid file is not match the os process pid number which is smaller than before.
this would be exist if the libvirtd process coredump or the os process was killed which the next pid number is smaller.
you can be also edit the pid file to write the longer number than before,then restart the libvirtd service.
Signed-off-by: Bobo Du <dubo163@126.com> --- src/util/virpidfile.c | 8 ++++++++ 1 file changed, 8 insertions(+)
ACKed and puhsed. Congratulations on your first libvirt contribution! Michal
Thanks! I will do it better in the future. At 2018-07-04 13:09:20, "Michal Prívozník" <mprivozn@redhat.com> wrote:
On 07/04/2018 05:55 AM, Bobo Du wrote:
the libvirtd pid file is not match the os process pid number which is smaller than before.
this would be exist if the libvirtd process coredump or the os process was killed which the next pid number is smaller.
you can be also edit the pid file to write the longer number than before,then restart the libvirtd service.
Signed-off-by: Bobo Du <dubo163@126.com> --- src/util/virpidfile.c | 8 ++++++++ 1 file changed, 8 insertions(+)
ACKed and puhsed.
Congratulations on your first libvirt contribution!
Michal
participants (3)
-
Bobo Du -
Michal Prívozník -
杜 博