[PATCH] bridge_driver: Drop needless fwd declarations
Some forward declarations in bridge_driver.c are not needed really. They only create a noise when trying to jump onto the correct tag. Drop them. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/network/bridge_driver.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 498c45d0a7..7e5fab630b 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -259,20 +259,6 @@ static int networkShutdownNetwork(virNetworkDriverState *driver, virNetworkObj *obj); -static int -networkStartNetworkVirtual(virNetworkDriverState *driver, - virNetworkObj *obj); - -static int -networkShutdownNetworkVirtual(virNetworkDriverState *driver, - virNetworkObj *obj); - -static int -networkStartNetworkExternal(virNetworkObj *obj); - -static int -networkShutdownNetworkExternal(virNetworkObj *obj); - static void networkReloadFirewallRules(virNetworkDriverState *driver, bool startup, -- 2.32.0
On Mon, 2021-11-08 at 11:47 +0100, Michal Privoznik wrote:
Some forward declarations in bridge_driver.c are not needed really. They only create a noise when trying to jump onto the correct tag. Drop them.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Tim Wiederhake <twiederh@redhat.com>
--- src/network/bridge_driver.c | 14 -------------- 1 file changed, 14 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 498c45d0a7..7e5fab630b 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -259,20 +259,6 @@ static int networkShutdownNetwork(virNetworkDriverState *driver, virNetworkObj *obj); -static int -networkStartNetworkVirtual(virNetworkDriverState *driver, - virNetworkObj *obj); - -static int -networkShutdownNetworkVirtual(virNetworkDriverState *driver, - virNetworkObj *obj); - -static int -networkStartNetworkExternal(virNetworkObj *obj); - -static int -networkShutdownNetworkExternal(virNetworkObj *obj); - static void networkReloadFirewallRules(virNetworkDriverState *driver, bool startup,
On Mon, Nov 08, 2021 at 11:47:27AM +0100, Michal Privoznik wrote:
Some forward declarations in bridge_driver.c are not needed really. They only create a noise when trying to jump onto the correct tag. Drop them.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
--- src/network/bridge_driver.c | 14 -------------- 1 file changed, 14 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 498c45d0a7..7e5fab630b 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -259,20 +259,6 @@ static int networkShutdownNetwork(virNetworkDriverState *driver, virNetworkObj *obj);
-static int -networkStartNetworkVirtual(virNetworkDriverState *driver, - virNetworkObj *obj); - -static int -networkShutdownNetworkVirtual(virNetworkDriverState *driver, - virNetworkObj *obj); - -static int -networkStartNetworkExternal(virNetworkObj *obj); - -static int -networkShutdownNetworkExternal(virNetworkObj *obj); - static void networkReloadFirewallRules(virNetworkDriverState *driver, bool startup, -- 2.32.0
participants (3)
-
Martin Kletzander -
Michal Privoznik -
Tim Wiederhake