On 01/31/2014 11:45 AM, Eric Blake wrote:
On 01/31/2014 09:35 AM, John Ferlan wrote:
> Coverity complains about default: label not be able to be reached. It's by
> design for the code, so just add a Coverity tag for dead_error_begin
>
> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
> ---
> src/libxl/libxl_driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index fc0efa2..513a597 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> @@ -4168,6 +4168,7 @@ libxlDomainGetNumaParameters(virDomainPtr dom,
>
> break;
>
> + /* coverity[dead_error_begin] */
> default:
> break;
> }
>
Why not just delete the label instead; then you don't need a Coverity
marker?
So are you advocating for removal of the other [dead_error_begin]
conditions in the same manner?
see src/lxc/lxc_driver.c (3 occurrences) and src/nodeinfo.c (1 occurrence).
John