On Mon, Jul 27, 2026 at 07:59:06PM +0100, Daniel P. Berrangé via Devel wrote:
On Fri, Jul 24, 2026 at 11:54:20PM +0200, Krzysztoff wrote:
More importantly - this change in the argument type makes absolutely no sense, since now the function lookupByUUID requires exactly the same argument as lookupByUUIDString - I suppose these functions were supposed to do different things but now they work exactly the same.
def lookupByUUID(self, uuid: "str") -> "virDomain":
Yes, this type annotation is wrong - it should be bytes, not string.
The underlying code impl has not changed, and still wants bytes. This is just the recently added type annotation that is broken.
I pushed fixes for this in https://gitlab.com/libvirt/libvirt-python/-/merge_requests/207 we've got a release pending in a couple of days, so if you can validate the changes fix it for you that'd be useful. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|