On 11/11/26 5:21 PM, Collin Walling wrote:
On 10/20/26 00:15, Rorie Reyes wrote:
[...]
+ + if (failIncompatible) { + if (responsibleProps && responsibleProps[0]) { + g_autofree char *props = g_strjoinv(", ", responsibleProps); + + virReportError(VIR_ERR_CPU_INCOMPATIBLE, + _("guest CPU model is not compatible with the destination host CPU model, differing properties: %1$s"), + props); A few nits:
1. What about changing to:
"... host CPU model; responsible properties: ..." ? It aligns with the responsibleProps variable.
2. s/not compatible/incompatible? Again, aligns with code. Or does that mess up translations? Thanks Collin, both suggestions make sense and align well with the codebase naming and libvirt style
+ } else { + virReportError(VIR_ERR_CPU_INCOMPATIBLE, "%s", + _("guest CPU model is not compatible with the destination host CPU model")); + } + return VIR_CPU_COMPARE_ERROR; + } + + return VIR_CPU_COMPARE_INCOMPATIBLE; +} [...]