Re: [libvirt] PATCH: Switch remote daemon to use memory alloc APIs

On Fri, May 30, 2008 at 03:37:06PM +0100, Daniel P. Berrange wrote: > THis patch switches over the remote daemon to use the memory allocation > APIs. This required exporting the 4 apis in the .so. I discovered along > the way that none of the remote RPC dispatcher impls checked for malloc > failure, so I've had to add that in too. Looks fine, this really cleans things up, especially reallocs > if (getsockname(sock->fd, (struct sockaddr *)(&sa), &salen) < 0) > - return -1; > + goto cleanup; > Hum, changes the semantic but it looks like it will avoid leaking file descriptors too..