Re: [libvirt] [PATCH] util: add note about event file descriptors on Windows

On 12/20/19 10:47 AM, Daniel P. Berrangé wrote:

When using GNULIB with Winsock, libvirt will never see the normal HANDLE objects, instead GNULIB guarantees that libvirt gets a C runtime file descriptor. The GNULIB poll impl also expects to get C runtime file descriptors rather than HANDLE objects. Document this behaviour so that it is clear to applications providing event loop implementations if they need Windows portability.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- include/libvirt/libvirt-event.h | 4 ++++ src/util/virevent.c | 7 +++++++ 2 files changed, 11 insertions(+)

Reviewed-by: Cole Robinson <crobinso@redhat.com> - Cole