From: Radoslaw Smigielski <rsmigiel@redhat.com> Wire existing completers for 'domxml-to-native --format', 'vol-create-as --format', 'vol-create-as --backing-vol-format', and 'attach-disk --source-host-socket'. Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9 Signed-off-by: Radoslaw Smigielski <rsmigiel@redhat.com> --- tools/virsh-domain.c | 2 ++ tools/virsh-volume.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index c1c27433b0bf..bd6c877b4521 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -521,6 +521,7 @@ static const vshCmdOptDef opts_attach_disk[] = { }, {.name = "source-host-socket", .type = VSH_OT_STRING, + .completer = vshCompletePathLocalExisting, .help = N_("host socket for source of disk device") }, {.name = "throttle-groups", @@ -10968,6 +10969,7 @@ static const vshCmdOptDef opts_domxmltonative[] = { .type = VSH_OT_STRING, .positional = true, .required = true, + .completer = virshDomainXMLNativeFormatCompleter, .help = N_("target config data type format") }, {.name = "domain", diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index 7346d628d55d..21471e0496e9 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -197,6 +197,7 @@ static const vshCmdOptDef opts_vol_create_as[] = { {.name = "format", .type = VSH_OT_STRING, .unwanted_positional = true, + .completer = virshDomainStorageFileFormatCompleter, .help = N_("file format type raw,bochs,qcow,qcow2,qed,vmdk") }, {.name = "backing-vol", @@ -207,6 +208,7 @@ static const vshCmdOptDef opts_vol_create_as[] = { {.name = "backing-vol-format", .type = VSH_OT_STRING, .unwanted_positional = true, + .completer = virshDomainStorageFileFormatCompleter, .help = N_("format of backing volume if taking a snapshot") }, {.name = "prealloc-metadata", -- 2.54.0