On Wed, Apr 22, 2026 at 18:46:47 +0200, Roman Bogorodskiy wrote:
Report error in case when incorrect index is specified for the ISA controller.
Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com> --- src/bhyve/bhyve_domain.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index 484f7b9d6e..d60e2b2ca0 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -323,6 +323,8 @@ bhyveDomainDeviceDefValidate(const virDomainDeviceDef *dev,
if (controller->type == VIR_DOMAIN_CONTROLLER_TYPE_ISA && controller->idx != 0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Bhyve ISA controller can only have index \'0\'"));
No need to escape ' in strings which use ".
return -1; } else if (controller->type == VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL) { if (controller->opts.vioserial.ports > 16) { -- 2.52.0
Reviewed-by: Peter Krempa <pkrempa@redhat.com>