Do not reject setvcpu --enable --async or setvcpus --guest --async in virsh. For setvcpu, async only affects live unplug and is documented as having no effect when enabling vCPUs. For setvcpus, guest+async is a driver-visible flag combination; drivers should decide whether they can support it. Keep virsh validation limited to API-level constraints and let drivers report unsupported combinations. Signed-off-by: Akash Kulhalli <akash.kulhalli@oracle.com> --- tools/virsh-domain.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 513129cda71b..0687a3190ead 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -7691,7 +7691,6 @@ cmdSetvcpus(vshControl *ctl, const vshCmd *cmd) VSH_EXCLUSIVE_OPTIONS_VAR(current, live); VSH_EXCLUSIVE_OPTIONS_VAR(current, config); VSH_EXCLUSIVE_OPTIONS_VAR(guest, config); - VSH_EXCLUSIVE_OPTIONS_VAR(async, guest); VSH_REQUIRE_OPTION_VAR(maximum, config); @@ -7864,7 +7863,6 @@ cmdSetvcpu(vshControl *ctl, const vshCmd *cmd) VSH_EXCLUSIVE_OPTIONS("current", "live"); VSH_EXCLUSIVE_OPTIONS("current", "config"); - VSH_EXCLUSIVE_OPTIONS("async", "enable"); if (config) flags |= VIR_DOMAIN_SETVCPU_AFFECT_CONFIG; -- 2.47.3