Re: [libvirt] PATCH: 4/28: Thread safety for test driver

On Mon, Dec 01, 2008 at 06:26:03PM +0100, Daniel Veillard wrote: > On Sun, Nov 30, 2008 at 11:27:14PM +0000, Daniel P. Berrange wrote: > I hope it's worth the effort, it's a lot of complexity added. > One of the things which worries me is that detecting errors will be > hard, you end up with a locked server that can be far from trivial > to debug. > I'm really wondering how we could automate testing or at least ease the > debug, It occurred to me that a static analysis tool like CIL really ought to be able to check correctness fairly easily. Rich has discussed this a little before http://et.redhat.com/~rjones/cil-analysis-of-libvirt/ Basically since we have a known set of functions which lock the object and CIL can give us the code flow within a method, we ought to be able to write something that looks at each call of virDomainFindByUUID, and then traces the code paths to functiuon return, and validates that the unlock call was made. It could likewise check for people calling things before acquiring the lock. Would be an interesting project..... :-)