Re: [PATCH v2 5/5] virsh: Add missing TAB completers for 'attach-disk' command

13 Aug 2026


      On Mon, Jul 13, 2026 at 12:14:51 +0200, Radosław Śmigielski via Devel wrote:
...
From: Radoslaw Smigielski <rsmigiel@redhat.com>
Add enum and static-list completers for 'attach-disk' options
targetbus, type, cache, io, mode, and sourcetype, and reuse the
existing storage file format completer for subdriver.
Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9
Signed-off-by: Radoslaw Smigielski <rsmigiel@redhat.com>
---
 tools/virsh-completer-domain.c | 74 ++++++++++++++++++++++++++++++++++
 tools/virsh-completer-domain.h | 30 ++++++++++++++
 tools/virsh-domain.c           |  7 ++++
Reviewed-by: Peter Krempa <pkrempa@redhat.com>