On Tue, Jun 23, 2026 at 06:26:01 +0000, Abhisek Panda wrote:
Build the tls-creds-psk object with the following params: id, dir, endpoint.
Note: Libvirt generates a keys.psk file for each migration session that only contains the pre-shared key for the "qemu" user. Because QEMU defaults to using "qemu" as the username if the username attribute of the tls-creds-psk object is undefined. We intentionally do not set this attribute.
Suggested-by: Tejus GK <tejus.gk@nutanix.com> Signed-off-by: Abhisek Panda <abhisek.panda1@nutanix.com> --- src/qemu/qemu_command.c | 26 ++++++++++++++++++++++++++ src/qemu/qemu_command.h | 7 +++++++ 2 files changed, 33 insertions(+) diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index e34172fbff..245c605b24 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -72,6 +72,13 @@ qemuBuildTLSx509BackendProps(const char *tlspath, const char *secalias, virJSONValue **propsret);
+/* Generate the object properties for a tls-creds-psk */ +int +qemuBuildTLSPSKBackendProps(const char *tlsPSKPath, + bool isListen, + const char *alias, + virJSONValue **propsret); +
This hunk has trailing whitespace, which breaks syntax-check:
MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MESON_TEST_ITERATION=1 ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 MALLOC_PERTURB_=51 /usr/bin/make -C /home/pipo/build/libvirt/gcc/build-aux sc_trailing_blank ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― stdout: make: Entering directory '/home/pipo/build/libvirt/gcc/build-aux' /home/pipo/libvirt/src/qemu/qemu_command.h:75:/* Generate the object properties for a tls-creds-psk */ /home/pipo/libvirt/src/qemu/qemu_command.h:76:int /home/pipo/libvirt/src/qemu/qemu_command.h:77:qemuBuildTLSPSKBackendProps(const char *tlsPSKPath, /home/pipo/libvirt/src/qemu/qemu_command.h:78: bool isListen, /home/pipo/libvirt/src/qemu/qemu_command.h:79: const char *alias, make: Leaving directory '/home/pipo/build/libvirt/gcc/build-aux' stderr: found trailing blank(s) make: *** [/home/pipo/libvirt/build-aux/syntax-check.mk:1136: sc_trailing_blank] Error 1
Make sure to run the test suite after each commit per our contributor guidelines for next posting. (note that I'll provide more detailed feedback in a while)