Re: [libvirt] [PATCH] xen: work with ia64 MAX_VIRT_CPUS of 64
On 11/01/2010 11:05 AM, Daniel P. Berrange wrote:
>>> + verify(MAX_VIRT_CPUS <= sizeof(1UL) * CHAR_BIT);
>
> Which version of gcc? This may be a bug in gnulib's verify module. I
> tested successfully on F13, gcc 4.4.4.
It fails on F12 gcc-4.4.3-4.fc12.x86_64, and on F 14 gcc-4.5.0-4.fc14.x86_64
Making it use verify_true() instead, works though
The difference being that verify() is a declaration, while verify_true()
is an integer constant expression.
OK, I'll prepare the patch along those lines.
In the meantime, I'm also seeing a failure when trying to compile in
rawhide:
xen/xend_internal.c: In function 'xenDaemonFormatSxpr':
xen/xend_internal.c:5775:112: error: 'MAX_VIRT_CPUS' undeclared (first
use in this function)
which was exactly what my patch was supposed to avoid, so I have to
figure out how to convince things to work with xen-devel-4.0.1-6.fc15
headers. :(
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)