On Wed, Apr 08, 2026 at 15:33:51 +0200, Peter Krempa via Devel wrote:
On Tue, Apr 07, 2026 at 19:35:41 -0400, Cole Robinson wrote:
On 4/7/26 5:13 AM, Peter Krempa wrote:
On Thu, Apr 02, 2026 at 11:12:28 -0400, Cole Robinson via Devel wrote:
[...]
Since you gave reviewed-by to 1-10 with comments, would you be fine with pushing those with function renamed and comments addressed, or rather I respin the whole series? I'm happy to do either
Once you rename qemuDomainGetImageIds and add error handling to it so that it can be used on code paths of inactive VMs you can use:
To be clear: - 11/16 should be reworked to pass in the definition and thus use proper seclabel; please post this one for review after you do that - 12/16 should not drop the 'cfg' argument from the leaf functions which operate on one image but rather pass it from the top. Also 'vm' argument ought to be first. With that and the rename+ error handling: Series: Reviewed-by: Peter Krempa <pkrempa@redhat.com>