On 9/2/26 20:49, Roman Bogorodskiy wrote:
Changes since v1:
Main changes are in the patch 2/3. The original series added lifecycle action handling to bhyve_monitor.c, but bhyve_driver.c still had the code to e.g. issue a shutdown command on reboot right away when onReboot was set to destroy, bypassing monitor. It does not play well together, and also it's confusing. In v2 monitor is the only place to handle lifecycle settings.
Roman Bogorodskiy (3): bhyve: add validation for lifecycle actions bhyve: monitor: respect on_poweroff / on_reboot settings bhyve: implement virDomainSetLifecycleAction() API
src/bhyve/bhyve_domain.c | 36 +++++++++++ src/bhyve/bhyve_domain.h | 3 + src/bhyve/bhyve_driver.c | 122 ++++++++++++++++++++++++++++++++++---- src/bhyve/bhyve_monitor.c | 20 +++++-- 4 files changed, 165 insertions(+), 16 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal