Re: [libvirt] [PATCH 10/19] storage: Create accessor API's for virStoragePoolObj
On 07/14/2017 09:55 AM, Pavel Hrdina wrote:
On Tue, May 09, 2017 at 11:30:17AM -0400, John Ferlan wrote:
> In preparation for making a private object, create accessor API's for
> consumer storage functions to use:
>
> virStoragePoolObjGetDef
> virStoragePoolObjGetNewDef
> virStoragePoolObjStealNewDef
> virStoragePoolObjGetConfigFile
> virStoragePoolObjSetConfigFile
> virStoragePoolObjIsActive
> virStoragePoolObjSetActive
> virStoragePoolObjGetAsyncjobs
> virStoragePoolObjIncrAsyncjobs
> virStoragePoolObjDecrAsyncjobs
>
> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
> ---
> src/conf/virstorageobj.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++++
> src/conf/virstorageobj.h | 36 +++++++++++++++++++----
> src/libvirt_private.syms | 10 +++++++
> 3 files changed, 115 insertions(+), 5 deletions(-)
Base on the review of following patches we need to add one more accessor
virStoragePoolObjGetAutostartLink().
I will place it right after virStoragePoolObjGetConfigFile since the
_virStoragePoolObj has autotstartLink after configFile.
John
The rest is OK.
Pavel