On Mon, Nov 06, 2023 at 12:42:58PM +0000, Daniel P. Berrangé wrote:
On Mon, Nov 06, 2023 at 12:04:09PM +0100, Andrea Bolognani wrote:
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1062214982
Assumes that
https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/444
has been merged, which it hasn't yet, but I don't expect it to be controversial.
You missed 442, which does the rpcgen change, and also fixes the missing glusterfs packages on 32-bit debian. Can you review that, since it'll impact the very first patch here.
Done. Below is the range-diff output, are you okay with me squashing those changes in or do you want me to respin? 1: efaca61f0f ! 1: cb98ea5298 ci: Update generated files @@ Metadata ## Commit message ## ci: Update generated files - Gain native gettext for MinGW containers, lose rpcgen everywhere. + Gain native gettext on MinGW, lose glusterfs on 32-bit + architectures and rpcgen everywhere. Signed-off-by: Andrea Bolognani <abologna@redhat.com> @@ ci/buildenv/debian-sid-cross-armv6l.sh: function install_buildenv() { libnbd-dev \ libxml2-utils \ locales \ +@@ ci/buildenv/debian-sid-cross-armv6l.sh: function install_buildenv() { + libdevmapper-dev:armel \ + libfuse-dev:armel \ + libglib2.0-dev:armel \ +- libglusterfs-dev:armel \ + libgnutls28-dev:armel \ + libiscsi-dev:armel \ + libnl-3-dev:armel \ ## ci/buildenv/debian-sid-cross-armv7l.sh ## @@ ci/buildenv/debian-sid-cross-armv7l.sh: function install_buildenv() { @@ ci/buildenv/debian-sid-cross-armv7l.sh: function install_buildenv() { libnbd-dev \ libxml2-utils \ locales \ +@@ ci/buildenv/debian-sid-cross-armv7l.sh: function install_buildenv() { + libdevmapper-dev:armhf \ + libfuse-dev:armhf \ + libglib2.0-dev:armhf \ +- libglusterfs-dev:armhf \ + libgnutls28-dev:armhf \ + libiscsi-dev:armhf \ + libnl-3-dev:armhf \ ## ci/buildenv/debian-sid-cross-i686.sh ## @@ ci/buildenv/debian-sid-cross-i686.sh: function install_buildenv() { @@ ci/buildenv/debian-sid-cross-i686.sh: function install_buildenv() { libnbd-dev \ libxml2-utils \ locales \ +@@ ci/buildenv/debian-sid-cross-i686.sh: function install_buildenv() { + libdevmapper-dev:i386 \ + libfuse-dev:i386 \ + libglib2.0-dev:i386 \ +- libglusterfs-dev:i386 \ + libgnutls28-dev:i386 \ + libiscsi-dev:i386 \ + libnl-3-dev:i386 \ ## ci/buildenv/debian-sid-cross-mips64el.sh ## @@ ci/buildenv/debian-sid-cross-mips64el.sh: function install_buildenv() { @@ ci/containers/debian-sid-cross-armv6l.Dockerfile: RUN export DEBIAN_FRONTEND=non libnbd-dev \ libxml2-utils \ locales \ +@@ ci/containers/debian-sid-cross-armv6l.Dockerfile: RUN export DEBIAN_FRONTEND=noninteractive && \ + libdevmapper-dev:armel \ + libfuse-dev:armel \ + libglib2.0-dev:armel \ +- libglusterfs-dev:armel \ + libgnutls28-dev:armel \ + libiscsi-dev:armel \ + libnl-3-dev:armel \ ## ci/containers/debian-sid-cross-armv7l.Dockerfile ## @@ ci/containers/debian-sid-cross-armv7l.Dockerfile: RUN export DEBIAN_FRONTEND=noninteractive && \ @@ ci/containers/debian-sid-cross-armv7l.Dockerfile: RUN export DEBIAN_FRONTEND=non libnbd-dev \ libxml2-utils \ locales \ +@@ ci/containers/debian-sid-cross-armv7l.Dockerfile: RUN export DEBIAN_FRONTEND=noninteractive && \ + libdevmapper-dev:armhf \ + libfuse-dev:armhf \ + libglib2.0-dev:armhf \ +- libglusterfs-dev:armhf \ + libgnutls28-dev:armhf \ + libiscsi-dev:armhf \ + libnl-3-dev:armhf \ ## ci/containers/debian-sid-cross-i686.Dockerfile ## @@ ci/containers/debian-sid-cross-i686.Dockerfile: RUN export DEBIAN_FRONTEND=noninteractive && \ @@ ci/containers/debian-sid-cross-i686.Dockerfile: RUN export DEBIAN_FRONTEND=nonin libnbd-dev \ libxml2-utils \ locales \ +@@ ci/containers/debian-sid-cross-i686.Dockerfile: RUN export DEBIAN_FRONTEND=noninteractive && \ + libdevmapper-dev:i386 \ + libfuse-dev:i386 \ + libglib2.0-dev:i386 \ +- libglusterfs-dev:i386 \ + libgnutls28-dev:i386 \ + libiscsi-dev:i386 \ + libnl-3-dev:i386 \ ## ci/containers/debian-sid-cross-mips64el.Dockerfile ## @@ ci/containers/debian-sid-cross-mips64el.Dockerfile: RUN export DEBIAN_FRONTEND=noninteractive && \ -- Andrea Bolognani / Red Hat / Virtualization