Re: [libvirt] [PATCH 1/2] Fix keymap used to talk with QEMU

>> +extern int (*codeOffsetVerify(void)) [verify_true (ARRAY_CARDINALITY(codeOffset) == VIR_KEYCODE_SET_LAST)]; \ > > Why the trailing backslash? > > Also, open-coding this verify is dangerous; gcc warnings have > changed over time, rendering certain verification styles that were > once safe into something that trips up -Werror. It is safer (and > shorter!) to let gnulib worry about gcc quirks, by changing this > line to just be: > > verify(ARRAY_CARDINALITY(codeOffset) == VIR_KEYCODE_SET_LAST); Yeah it was a stupid cut+paste from src/util/util.h where we had to open-code it for the enums, because the gnulib macro resulted in clashing symbols when used more than one.