On Mon, May 25, 2026 at 09:45:19 +0200, Radoslaw Smigielski wrote:
On Mon, 25 May 2026 at 08:56, Peter Krempa <pkrempa@redhat.com> wrote:
On Fri, May 22, 2026 at 18:57:48 +0200, Radoslaw Smigielski via Devel
wrote:
The --engine flag was being added to positional_args before the "run" subcommand, which resulted in incorrect lcitool invocations:
lcitool container --engine podman run ... (wrong)
This caused "invalid choice: 'podman'" errors because lcitool expected a COMMAND argument at that position.
Fix by moving the --engine flag to opts array, which is added after the "run" subcommand, resulting in the correct command structure:
lcitool container run --engine podman ... (correct)
Example:
$ ./ci/helper run fedora-44 --job codestyle --engine podman usage: lcitool container [-h] COMMAND ... lcitool container: error: argument COMMAND: invalid choice: 'podman' (choose from engines, build, run, shell)
The same error happens if "--engine" option is set to different than "auto" value.
Signed-off-by: Radoslaw Smigielski <rsmigiel@redhat.com> --- ci/helper | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
For libvirt-ci changes please submit a Merge request against the upstream repo: https://gitlab.com/libvirt/libvirt-ci
Hi Peter, It's a little bit misleading, and maybe my summary should refelect better what is this change about, sorry for that.
"ci/helper" script is part of libvirt repo but it's used by CI machiery so this I why I send it here.
Ah, oops. I'm too used for stuff under ci/ to be just re-generated from libvirt-ci and didn't even realize this is a script in libvirt repo with seemingly no counterpart there.