On 03/30/2012 10:54 AM, Daniel P. Berrange wrote:
On Fri, Mar 30, 2012 at 10:35:41AM -0600, Eric Blake wrote:
We are so close to a release that we don't want to pull in a gnulib submodule update and risk regressions, since there has been a lot of other gnulib churn upstream. However, there are a couple of gnulib issues that are worth fixing in isolation, by applying local patches to gnulib.
+ $(MAKE) $(release-prep-hook) RELEASE_TYPE=$@ + $(MAKE) -s emit_upload_commands RELEASE_TYPE=$@ + diff --git a/src/libvirt.c b/src/libvirt.c
This diff added a trailing blank line, as well as some space-tab indentation.
ACK
I made an additional tweak to cfg.mk to avoid syntax-check failures, as well as exempting gnulib/local/*/*.diff from whitespace checking, then pushed. I suspect we will revert the local diffs when we next update the .gnulib submodule, but that will be post-0.9.11. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org