On 5/21/26 18:23, Peter Krempa via Devel wrote:
The goal of this series is to replace the fake FDs and hacks to make the test output stable by a filter which stabilizes the output and then uses real FDs.
That way the test cases don't break but also environment changes will not influence the tests.
The series is for now missing a patch that will alert if a fake FD is used because it didn't play nice with valgrind and I'll thus post it later once I fix it.
Peter Krempa (30): qemuxmlconftest: Remove unused 'monitor_chr' from testCompareXMLToArgv qemu: Stop mocking 'qemuOpenChrChardevUNIXSocket' util: command: Extract common parts of FD closing to virCommandMassClose qemuFDPassLogFDInfo: Check if FD is valid before 'fstat'-ing it qemuxml2argvmock: Fix behaviour of 'virCommandPass' mock util: vircommand: Add direct accessor for 'args' array for tests qemuxmlconftest: Use virCommandArgListAccess in testCompareXMLToArgvValidateSchema util: command: Remove virCommandGetArgList util: json: Introduce 'virJSONValueObjectReplaceKey' testutils: Introduce virTestMakeDummyFD qemuxmlconftest: Move mock'd FDs further out qemuxmlconftest: Stablilize '-add-fd' arguments qemumonitorjsontest: Stabilize FD names in '-chardev' qemuxmlconftest: Stabilize FDs in iommufd objects qemuxmlconftest: Stabilize 'vsock' 'vhostfd' file descriptior in output files qemuxmlconftest: Stabilize fds in '-netdev' qemuxmlconftest: Stabilize 'vfio-pci' hostdev fds testutilsqemu: Use real FD for monitor FDs instantiated by 'testQemuPrepareHostBackendChardevOne' testQemuInfoSetArgs: Use real FDs with 'ARG_FD_GROUP' virDomainFDTuple: drop 'testfds' field testQemuPrepareHostBackendChardevOne: Use real FDs for all cases qemuxmlconftest: Setup real FDs for 'vhost-user-vga' qemuxml2argvmoc: qemuBuildTPMOpenBackendFDs: Use real FDs qemuxmlconftest: (consistently) use real FDs in tests for VDPA netdevs qemuxmlconftest: Use virTestMakeDummyFD() to get VDPA disk fds testutilsqemu: Remove unused 'ARG_VDPA_FD' test argument qemuxmlconftest: Use real FDS for testing of 'vsock' qemuxml2argvmock: Use real FDs for interface tests qemuxmlconftest: Use real FDs for hostdev tests qemuxmlconftest: Use real FD for iommufd object in tests
1192 files changed, 1882 insertions(+), 1575 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal