Re: [PATCH] vmx: Add support for NVRAM configuration

24 Apr 2026


      On Tue, Apr 21, 2026 at 19:36:25 -0000, surygupt--- via Devel wrote:
...
Peter Krempa wrote:
...
...
+        if (!def->os.loader) {
+            def->os.loader = virDomainLoaderDefNew();
Can this ever be already allocated? [2]
[2] I'm asking because this then could overwrite existing value here
leaking the original.
I checked virVMXParseConfig(), it creates a fresh virDomainDef at line 1460
so the nil check can be removed and simplified to:
def->os.loader = virDomainLoaderDefNew();
I have fixed other changes as you suggested, do let me know if above looks good.
Will send v2 shortly with all fixes applied.
Yes this makes sense.