I question whether this patch is even needed. Related APIs such as virtDomainShutdown*, virtDomainReset, etc make no mention of events that might be emitted. I'd be in favor of dropping it. On 11/9/26 4:47 AM, Ben Grande wrote:
Signed-off-by: Ben Grande <ben@invisiblethingslab.com> --- src/libvirt-domain.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index acd9ffc44b..f1d4a30c2e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -1779,7 +1779,10 @@ virDomainShutdownFlags(virDomainPtr domain, unsigned int flags) * Note that the guest OS may ignore the request. * Additionally, the hypervisor may check and support the domain * 'on_reboot' XML setting resulting in a domain that shuts down instead - * of rebooting. + * of rebooting. When 'on_reboot' isn't 'restart', drivers that support it will + * emit a VIR_DOMAIN_EVENT_STOPPED lifecycle event with detail + * VIR_DOMAIN_EVENT_STOPPED_REBOOT. For more information, see + * https://libvirt.org/formatdomain.html#events-configuration
This doesn't match libxl driver behavior anyhow, which will emit a VIR_DOMAIN_EVENT_STOPPED event regardless of 'on_reboot' setting. Regards, Jim