[PATCH] Use live migration if MigrationType isn't defined in MSD

# HG changeset patch # User Kaitlin Rupert <karupert@us.ibm.com> # Date 1205362434 25200 # Node ID df3c20a332e01e4e9f90f6ccdc61857515d57a7f # Parent b739fc9b13320e07a39f3932396c8411c2d4ad75 Use live migration if MigrationType isn't defined in MSD. diff -r b739fc9b1332 -r df3c20a332e0 src/Virt_VSMigrationService.c --- a/src/Virt_VSMigrationService.c Tue Mar 11 13:28:04 2008 -0700 +++ b/src/Virt_VSMigrationService.c Wed Mar 12 15:53:54 2008 -0700 @@ -100,9 +100,8 @@ static CMPIStatus get_migration_type(CMP ret = cu_get_u16_prop(msd, "MigrationType", type); if (ret != CMPI_RC_OK) { - cu_statusf(_BROKER, &s, - ret, - "Invalid MigrationType value"); + CU_DEBUG("Using default MigrationType: %d", CIM_MIGRATE_LIVE); + *type = CIM_MIGRATE_LIVE; } return s;

Kaitlin Rupert wrote:
# HG changeset patch # User Kaitlin Rupert <karupert@us.ibm.com> # Date 1205362434 25200 # Node ID df3c20a332e01e4e9f90f6ccdc61857515d57a7f # Parent b739fc9b13320e07a39f3932396c8411c2d4ad75 Use live migration if MigrationType isn't defined in MSD.
diff -r b739fc9b1332 -r df3c20a332e0 src/Virt_VSMigrationService.c --- a/src/Virt_VSMigrationService.c Tue Mar 11 13:28:04 2008 -0700 +++ b/src/Virt_VSMigrationService.c Wed Mar 12 15:53:54 2008 -0700 @@ -100,9 +100,8 @@ static CMPIStatus get_migration_type(CMP
ret = cu_get_u16_prop(msd, "MigrationType", type); if (ret != CMPI_RC_OK) { - cu_statusf(_BROKER, &s, - ret, - "Invalid MigrationType value"); + CU_DEBUG("Using default MigrationType: %d", CIM_MIGRATE_LIVE); + *type = CIM_MIGRATE_LIVE; }
return s;
Man, VSMigrationService is getting all the action lately. I don't see any members being added to the migration_job struct, so I'd imagine this is safe. :) +1 -- -Jay

KR> # HG changeset patch KR> # User Kaitlin Rupert <karupert@us.ibm.com> KR> # Date 1205362434 25200 KR> # Node ID df3c20a332e01e4e9f90f6ccdc61857515d57a7f KR> # Parent b739fc9b13320e07a39f3932396c8411c2d4ad75 KR> Use live migration if MigrationType isn't defined in MSD. Can we get a Signed-off-by in here? -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com

Dan Smith wrote:
KR> # HG changeset patch KR> # User Kaitlin Rupert <karupert@us.ibm.com> KR> # Date 1205362434 25200 KR> # Node ID df3c20a332e01e4e9f90f6ccdc61857515d57a7f KR> # Parent b739fc9b13320e07a39f3932396c8411c2d4ad75 KR> Use live migration if MigrationType isn't defined in MSD.
Can we get a Signed-off-by in here?
Eeek - not sure how that was missed. Thanks for catching it. I'll resend. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (3)
-
Dan Smith
-
Jay Gagnon
-
Kaitlin Rupert