[PATCH] fix id parsing with white space
When device id string contains white space, parse is not correct. This patch fix it Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com> --- libxkutil/device_parsing.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libxkutil/device_parsing.c b/libxkutil/device_parsing.c index 5393290..ceb4552 100644 --- a/libxkutil/device_parsing.c +++ b/libxkutil/device_parsing.c @@ -1033,7 +1033,7 @@ int parse_fq_devid(const char *devid, char **host, char **device) { int ret; - ret = sscanf(devid, "%a[^/]/%as", host, device); + ret = sscanf(devid, "%a[^/]/%a[^\n]", host, device); if (ret != 2) { free(*host); free(*device); -- 1.7.1
+1 Quoting Wenchao Xia <xiawenc@linux.vnet.ibm.com>:
When device id string contains white space, parse is not correct. This patch fix it
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com> --- libxkutil/device_parsing.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libxkutil/device_parsing.c b/libxkutil/device_parsing.c index 5393290..ceb4552 100644 --- a/libxkutil/device_parsing.c +++ b/libxkutil/device_parsing.c @@ -1033,7 +1033,7 @@ int parse_fq_devid(const char *devid, char **host, char **device) { int ret;
- ret = sscanf(devid, "%a[^/]/%as", host, device); + ret = sscanf(devid, "%a[^/]/%a[^\n]", host, device); if (ret != 2) { free(*host); free(*device); -- 1.7.1
On Fri, Aug 03, 2012 at 03:36:59PM +0800, Wenchao Xia wrote:
When device id string contains white space, parse is not correct. This patch fix it
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com> --- libxkutil/device_parsing.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
ACK, pushed, but giving an example would be useful, I don't know any device with space in its name Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
sorry for missed that in doc, before this patch assoication with the pool contain space in it would fail. 2012-09-15 Best Regards Wenchao Xia 发件人：Daniel Veillard 发送时间：2012-09-14 16:36 主题：Re: [Libvirt-cim] [PATCH] fix id parsing with white space 收件人："Wenchao Xia"<xiawenc@linux.vnet.ibm.com> 抄送："libvirt-cim"<libvirt-cim@redhat.com> On Fri, Aug 03, 2012 at 03:36:59PM +0800, Wenchao Xia wrote:
When device id string contains white space, parse is not correct. This patch fix it
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com> --- libxkutil/device_parsing.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
ACK, pushed, but giving an example would be useful, I don't know any device with space in its name Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ _______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
participants (4)
-
Daniel Veillard -
snmishra＠linux.vnet.ibm.com -
Wenchao Xia -
xiaxia347work