[PATCH] [Test] Fix ElementConforms/02_reverse.py with sblim-cmpi-base provider installed
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1228203734 28800 # Node ID 5bd7b6bf455d719006acfb15c3b0bc4859d3f296 # Parent 5fb94ae83ed121d3b0ce54bde7e30175c2df6f70 [Test] Fix ElementConforms/02_reverse.py with sblim-cmpi-base provider installed Signed-off-by: Guolian Yun <yunguol@cn.ibm.com> diff -r 5fb94ae83ed1 -r 5bd7b6bf455d suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py --- a/suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py Wed Nov 26 19:06:58 2008 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py Mon Dec 01 23:42:14 2008 -0800 @@ -159,12 +159,13 @@ if status != PASS: cxml.undefine(server) return status - - status = verify_profile(profs[0], exp_list[cn]) - if status != PASS: - logger.error("Verification of profile instance failed") - cxml.undefine(server) - return FAIL + + if cn != 'Linux_ComputerSystem': + status = verify_profile(profs[0], exp_list[cn]) + if status != PASS: + logger.error("Verification of profile instance failed") + cxml.undefine(server) + return FAIL except Exception, detail: logger.error(CIM_ERROR_ASSOCIATORS, an)
yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1228203734 28800 # Node ID 5bd7b6bf455d719006acfb15c3b0bc4859d3f296 # Parent 5fb94ae83ed121d3b0ce54bde7e30175c2df6f70 [Test] Fix ElementConforms/02_reverse.py with sblim-cmpi-base provider installed
Signed-off-by: Guolian Yun <yunguol@cn.ibm.com>
diff -r 5fb94ae83ed1 -r 5bd7b6bf455d suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py --- a/suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py Wed Nov 26 19:06:58 2008 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py Mon Dec 01 23:42:14 2008 -0800 @@ -159,12 +159,13 @@ if status != PASS: cxml.undefine(server) return status - - status = verify_profile(profs[0], exp_list[cn]) - if status != PASS: - logger.error("Verification of profile instance failed") - cxml.undefine(server) - return FAIL + + if cn != 'Linux_ComputerSystem': + status = verify_profile(profs[0], exp_list[cn]) + if status != PASS: + logger.error("Verification of profile instance failed") + cxml.undefine(server) + return FAIL
Even if the host instance is a Linux_ComputerSystem instance, we want to verify the providers. The problem here is that when the SBLIM providers are installed, cn == "Linux_ComputerSystem". The exp_list[] doesn't have a "Linux_ComputerSystem" value. So you'll need to convert cn from "Linux_ComputerSystem" to "<virt type>_HostSystem" -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
libvirt-cim-bounces@redhat.com wrote on 2008-12-03 02:46:27:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1228203734 28800 # Node ID 5bd7b6bf455d719006acfb15c3b0bc4859d3f296 # Parent 5fb94ae83ed121d3b0ce54bde7e30175c2df6f70 [Test] Fix ElementConforms/02_reverse.py with sblim-cmpi-base
yunguol@cn.ibm.com wrote: provider installed
Signed-off-by: Guolian Yun <yunguol@cn.ibm.com>
diff -r 5fb94ae83ed1 -r 5bd7b6bf455d suites/libvirt-
cim/cimtest/ElementConforms/02_reverse.py
--- a/suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py Wed Nov 26 19:06:58 2008 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py Mon Dec 01 23:42:14 2008 -0800 @@ -159,12 +159,13 @@ if status != PASS: cxml.undefine(server) return status - - status = verify_profile(profs[0], exp_list[cn]) - if status != PASS: - logger.error("Verification of profile instance failed") - cxml.undefine(server) - return FAIL + + if cn != 'Linux_ComputerSystem': + status = verify_profile(profs[0], exp_list[cn]) + if status != PASS: + logger.error("Verification of profile instance failed") + cxml.undefine(server) + return FAIL
Even if the host instance is a Linux_ComputerSystem instance, we want to
verify the providers.
The problem here is that when the SBLIM providers are installed, cn == "Linux_ComputerSystem". The exp_list[] doesn't have a "Linux_ComputerSystem" value. So you'll need to convert cn from "Linux_ComputerSystem" to "<virt type>_HostSystem"
Done, also remove XFAIL_RC in this test. Thanks!
-- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1228203734 28800 # Node ID 5bd7b6bf455d719006acfb15c3b0bc4859d3f296 # Parent 5fb94ae83ed121d3b0ce54bde7e30175c2df6f70 [Test] Fix ElementConforms/02_reverse.py with sblim-cmpi-base provider installed
Signed-off-by: Guolian Yun <yunguol@cn.ibm.com>
diff -r 5fb94ae83ed1 -r 5bd7b6bf455d suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py --- a/suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py Wed Nov 26 19:06:58 2008 -0800 +++ b/suites/libvirt-cim/cimtest/ElementConforms/02_reverse.py Mon Dec 01 23:42:14 2008 -0800 @@ -159,12 +159,13 @@
Also, can you remove the XFAIL from this test? It is no longer needed. Thanks! -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (3)
-
Guo Lian Yun -
Kaitlin Rupert -
yunguol＠cn.ibm.com