[PATCH] [TEST] Update SystemDevice[01_forward.py] to verify the DisplayController and PointingDevice with SystemDevice
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1228723896 28800 # Node ID f346e561aa615d79c547fb3d8bce3e49256493f4 # Parent 701f3228bdfe740f4a504dce1dfab844c812b9d5 [TEST] Update SystemDevice[01_forward.py] to verify the DisplayController and PointingDevice with SystemDevice. Signed-off-by: Guolian Yun <yunguol@cn.ibm.com> diff -r 701f3228bdfe -r f346e561aa61 suites/libvirt-cim/cimtest/SystemDevice/01_forward.py --- a/suites/libvirt-cim/cimtest/SystemDevice/01_forward.py Wed Dec 03 21:31:09 2008 -0800 +++ b/suites/libvirt-cim/cimtest/SystemDevice/01_forward.py Mon Dec 08 00:11:36 2008 -0800 @@ -90,8 +90,12 @@ if virt != 'LXC': net_cn = get_typed_class(virt, "NetworkPort") disk_cn = get_typed_class(virt, "LogicalDisk") + input_cn = get_typed_class(virt, "PointingDevice") + graphics_cn = get_typed_class(virt, "DisplayController") exp_pllist[net_cn] = ['%s/%s' % (test_dom, test_mac)] exp_pllist[disk_cn] = [ '%s/%s' % (test_dom, test_disk)] + exp_pllist[input_cn] = ['%s/mouse:ps2' % test_dom] + exp_pllist[graphics_cn] = ['%s/graphics' % test_dom] try: res_pllist = {}
The test fails with this updates because of Device Class mismatch as follows: ERROR - Exception Expected Device class list: ['KVM_DisplayController', 'KVM_LogicalDisk', 'KVM_Memory', 'KVM_NetworkPort', 'KVM_PointingDevice', 'KVM_Processor'] Got: [u'KVM_LogicalDisk', u'KVM_Memory', u'KVM_NetworkPort', u'KVM_Processor'] I have to set input and graphics devices in vs define if I try to verify them, then the test can return virt_DisplayController and virt_PointingDevice. So we have to update vxml.py to make it support input and graphics devices, right? Thanks! Best, Regards Daisy (运国莲) VSM Team, China Systems & Technology Labs (CSTL) E-mail: yunguol@cn.ibm.com TEL: (86)-21-60922403 Building 10, 399 Ke Yuan Rd, Pudong Shanghai, 201203 Guo Lian Yun/China/IBM@IBMCN Sent by: libvirt-cim-bounces@redhat.com 2008-12-08 16:11 Please respond to List for discussion and development of libvirt CIM <libvirt-cim@redhat.com> To libvirt-cim@redhat.com cc Subject [Libvirt-cim] [PATCH] [TEST] Update SystemDevice[01_forward.py] to verify the DisplayController and PointingDevice with SystemDevice # HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1228723896 28800 # Node ID f346e561aa615d79c547fb3d8bce3e49256493f4 # Parent 701f3228bdfe740f4a504dce1dfab844c812b9d5 [TEST] Update SystemDevice[01_forward.py] to verify the DisplayController and PointingDevice with SystemDevice. Signed-off-by: Guolian Yun <yunguol@cn.ibm.com> diff -r 701f3228bdfe -r f346e561aa61 suites/libvirt-cim/cimtest/SystemDevice/01_forward.py --- a/suites/libvirt-cim/cimtest/SystemDevice/01_forward.py Wed Dec 03 21:31:09 2008 -0800 +++ b/suites/libvirt-cim/cimtest/SystemDevice/01_forward.py Mon Dec 08 00:11:36 2008 -0800 @@ -90,8 +90,12 @@ if virt != 'LXC': net_cn = get_typed_class(virt, "NetworkPort") disk_cn = get_typed_class(virt, "LogicalDisk") + input_cn = get_typed_class(virt, "PointingDevice") + graphics_cn = get_typed_class(virt, "DisplayController") exp_pllist[net_cn] = ['%s/%s' % (test_dom, test_mac)] exp_pllist[disk_cn] = [ '%s/%s' % (test_dom, test_disk)] + exp_pllist[input_cn] = ['%s/mouse:ps2' % test_dom] + exp_pllist[graphics_cn] = ['%s/graphics' % test_dom] try: res_pllist = {} _______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
Guo Lian Yun wrote:
The test fails with this updates because of Device Class mismatch as follows:
ERROR - Exception Expected Device class list: ['KVM_DisplayController', 'KVM_LogicalDisk', 'KVM_Memory', 'KVM_NetworkPort', 'KVM_PointingDevice', 'KVM_Processor'] Got: [u'KVM_LogicalDisk', u'KVM_Memory', u'KVM_NetworkPort', u'KVM_Processor']
I have to set input and graphics devices in vs define if I try to verify them, then the test can return virt_DisplayController and virt_PointingDevice. So we have to update vxml.py to make it support input and graphics devices, right? Thanks!
Yes, we need to add input and graphics devices to guests in order to test them. You'll need to branch vxml.py since the F9 rpm won't support defining guests with input/graphics devices. Thanks! -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
libvirt-cim-bounces@redhat.com wrote on 2008-12-09 03:10:29:
Guo Lian Yun wrote:
The test fails with this updates because of Device Class mismatch as follows:
ERROR - Exception Expected Device class list: ['KVM_DisplayController', 'KVM_LogicalDisk', 'KVM_Memory', 'KVM_NetworkPort', 'KVM_PointingDevice', 'KVM_Processor'] Got: [u'KVM_LogicalDisk', u'KVM_Memory', u'KVM_NetworkPort',
u'KVM_Processor']
I have to set input and graphics devices in vs define if I try to verify them, then the test can return virt_DisplayController and virt_PointingDevice. So we have to update vxml.py to make it support input and graphics devices, right? Thanks!
Yes, we need to add input and graphics devices to guests in order to test them. You'll need to branch vxml.py since the F9 rpm won't support
defining guests with input/graphics devices.
I think it's better to add branch in test case instead of vxml.py, or we have to pass ip address to get_provider_version(virt, server) in XenXML/KVMXML/XenFVXML class. Thanks!
Thanks!
-- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
_______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com https://www.redhat.com/mailman/listinfo/libvirt-cim
yunguol@cn.ibm.com wrote:
# HG changeset patch # User Guolian Yun <yunguol@cn.ibm.com> # Date 1228723896 28800 # Node ID f346e561aa615d79c547fb3d8bce3e49256493f4 # Parent 701f3228bdfe740f4a504dce1dfab844c812b9d5 [TEST] Update SystemDevice[01_forward.py] to verify the DisplayController and PointingDevice with SystemDevice.
Signed-off-by: Guolian Yun <yunguol@cn.ibm.com>
diff -r 701f3228bdfe -r f346e561aa61 suites/libvirt-cim/cimtest/SystemDevice/01_forward.py --- a/suites/libvirt-cim/cimtest/SystemDevice/01_forward.py Wed Dec 03 21:31:09 2008 -0800 +++ b/suites/libvirt-cim/cimtest/SystemDevice/01_forward.py Mon Dec 08 00:11:36 2008 -0800 @@ -90,8 +90,12 @@ if virt != 'LXC': net_cn = get_typed_class(virt, "NetworkPort") disk_cn = get_typed_class(virt, "LogicalDisk") + input_cn = get_typed_class(virt, "PointingDevice") + graphics_cn = get_typed_class(virt, "DisplayController") exp_pllist[net_cn] = ['%s/%s' % (test_dom, test_mac)] exp_pllist[disk_cn] = [ '%s/%s' % (test_dom, test_disk)] + exp_pllist[input_cn] = ['%s/mouse:ps2' % test_dom] + exp_pllist[graphics_cn] = ['%s/graphics' % test_dom]
Can you resend this patch when you send your vxml.py changes? I don't want to apply this now since it will cause the test to fail. -- Kaitlin Rupert IBM Linux Technology Center kaitlin@linux.vnet.ibm.com
participants (3)
-
Guo Lian Yun -
Kaitlin Rupert -
yunguol＠cn.ibm.com